fix: remove trailing slashes from bucket name. #266
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
ghost
assigned 
|
@stephenplusplus @callmehiphop what's the latest on this one? |
Codecov Report
@@ Coverage Diff @@
## master #266 +/- ##
=====================================
Coverage 100% 100%
=====================================
Files 7 7
Lines 1031 1031
=====================================
Hits 1031 1031
Continue to review full report at Codecov.
|
stephenplusplus
force-pushed
the
spp--170
branch
from
2515433
to
55c4961
Compare
|
I've modernized the PR, and it should be good for a review. |
JustinBeckwith
approved these changes
Sep 5, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #170
This cleans up the fragments of a gs:// URL, should the user provide one to the Bucket constructor.