chore(typescript): enable noImplicitAny (#483)

googleapis · Oct 24, 2018 · d50d25b · d50d25b
1 parent 230a54d
commit d50d25b
Show file tree

Hide file tree

Showing 5 changed files with 228 additions and 170 deletions.
diff --git a/package.json b/package.json
@@ -106,6 +106,7 @@
     "@types/async": "^2.0.49",
     "@types/compressible": "^2.0.0",
     "@types/concat-stream": "^1.6.0",
+    "@types/configstore": "^2.1.1",
     "@types/extend": "^3.0.0",
     "@types/mime": "^2.0.0",
     "@types/mime-types": "^2.1.0",

diff --git a/src/bucket.ts b/src/bucket.ts
@@ -409,7 +409,7 @@ export type GetBucketMetadataResponse = [Metadata, request.Response];
  * @param {object} metadata The bucket metadata.
  * @param {object} apiResponse The full API response.
  */
-export interface GetBucketMetadataCallback extends GetMetadataCallback {
+export interface GetBucketMetadataCallback {
   (err: ApiError|null, metadata: Metadata|null,
    apiResponse: request.Response): void;
 }
@@ -610,7 +610,7 @@ export type UploadResponse = [File, request.Response];
  * @param {object} apiResponse The full API response.
  */
 export interface UploadCallback {
-  (err?: Error|null, file?: File|null, apiResponse?: request.Response): void;
+  (err: Error|null, file?: File|null, apiResponse?: request.Response): void;
 }
 
 /**
@@ -2909,9 +2909,9 @@ class Bucket extends ServiceObject {
    * Example of uploading an encrypted file:
    */
   upload(pathString: string, options?: UploadOptions): Promise<UploadResponse>;
-  upload(pathString: string, callback: UploadCallback): void;
   upload(pathString: string, options: UploadOptions, callback: UploadCallback):
       void;
+  upload(pathString: string, callback: UploadCallback): void;
   upload(
       pathString: string, optionsOrCallback?: UploadOptions|UploadCallback,
       callback?: UploadCallback): Promise<UploadResponse>|void {

diff --git a/src/iam.ts b/src/iam.ts
@@ -363,10 +363,12 @@ class Iam {
 
           const availablePermissions = arrify(resp.permissions);
 
-          const permissionsHash = permissionsArray.reduce((acc, permission) => {
-            acc[permission] = availablePermissions.indexOf(permission) > -1;
-            return acc;
-          }, {});
+          const permissionsHash = permissionsArray.reduce(
+              (acc: {[index: string]: boolean}, permission) => {
+                acc[permission] = availablePermissions.indexOf(permission) > -1;
+                return acc;
+              },
+              {});
 
           cb!(null, permissionsHash, resp);
         });