-
Notifications
You must be signed in to change notification settings - Fork 3
feat(samples): Add POSIX & Manifest samples #67
Conversation
Here is the summary of changes. You are about to add 4 region tags.
This comment is generated by snippet-bot.
|
Warning: This pull request is touching the following templated files:
|
// The ID of the GCS bucket to transfer data to | ||
// const gcsSinkBucket = 'my-sink-bucket' | ||
|
||
// Transfer manifest location. Must be a |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Must be a what?
// const sourceAgentPoolName = 'projects/my-project/agentPools/transfer_service_default' | ||
|
||
// The root directory path on the source filesystem | ||
// const rootDirectory = '/directory/to/transfer/source', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Trailing comma here
// const gcsSourcePath = 'foo/bar/' | ||
|
||
// The root directory path on the source filesystem | ||
// const rootDirectory = '/directory/to/transfer/source', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
trailing comma
/** | ||
* Creates a request to transfer from the local file system to the sink bucket | ||
*/ | ||
async function transferDirectory() { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is "transferDirectory" the right name for this function? This only transfers the files specified in the manifest right? which may not be the entire directory if i understand it correctly, and may in fact include files from multiple directories within the root directory
🤖 I have created a release *beep* *boop* --- ## [2.1.0](v2.0.0...v2.1.0) (2022-06-30) ### Features * **samples:** Add POSIX & Manifest samples ([#67](#67)) ([1056c9f](1056c9f)) * support regapic LRO ([#75](#75)) ([cc80906](cc80906)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
🤖 I have created a release *beep* *boop* --- ## [2.1.0](googleapis/nodejs-storage-transfer@v2.0.0...v2.1.0) (2022-06-30) ### Features * **samples:** Add POSIX & Manifest samples ([#67](googleapis/nodejs-storage-transfer#67)) ([1056c9f](googleapis/nodejs-storage-transfer@1056c9f)) * support regapic LRO ([#75](googleapis/nodejs-storage-transfer#75)) ([cc80906](googleapis/nodejs-storage-transfer@cc80906)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
🤖 I have created a release *beep* *boop* --- ## [2.1.0](googleapis/nodejs-storage-transfer@v2.0.0...v2.1.0) (2022-06-30) ### Features * **samples:** Add POSIX & Manifest samples ([#67](googleapis/nodejs-storage-transfer#67)) ([1056c9f](googleapis/nodejs-storage-transfer@1056c9f)) * support regapic LRO ([#75](googleapis/nodejs-storage-transfer#75)) ([cc80906](googleapis/nodejs-storage-transfer@cc80906)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
No description provided.