Skip to content
This repository has been archived by the owner on Jul 20, 2023. It is now read-only.

feat(samples): Add POSIX & Manifest samples #67

Merged
merged 28 commits into from
Jun 14, 2022
Merged

Conversation

danielbankhead
Copy link
Contributor

No description provided.

@danielbankhead danielbankhead requested a review from a team as a code owner May 26, 2022 20:56
@product-auto-label product-auto-label bot added the size: m Pull request size is medium. label May 26, 2022
@snippet-bot
Copy link

snippet-bot bot commented May 26, 2022

Here is the summary of changes.

You are about to add 4 region tags.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

@product-auto-label product-auto-label bot added api: storagetransfer Issues related to the googleapis/nodejs-storage-transfer API. samples Issues that are directly related to samples. labels May 26, 2022
@generated-files-bot
Copy link

Warning: This pull request is touching the following templated files:

@product-auto-label product-auto-label bot added size: l Pull request size is large. and removed size: m Pull request size is medium. labels May 27, 2022
@danielbankhead danielbankhead changed the title feat(samples): Add POSIX samples feat(samples): Add POSIX & Manifest samples Jun 3, 2022
@danielbankhead danielbankhead merged commit 1056c9f into main Jun 14, 2022
@danielbankhead danielbankhead deleted the posix-samples branch June 14, 2022 21:53
// The ID of the GCS bucket to transfer data to
// const gcsSinkBucket = 'my-sink-bucket'

// Transfer manifest location. Must be a
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Must be a what?

// const sourceAgentPoolName = 'projects/my-project/agentPools/transfer_service_default'

// The root directory path on the source filesystem
// const rootDirectory = '/directory/to/transfer/source',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Trailing comma here

// const gcsSourcePath = 'foo/bar/'

// The root directory path on the source filesystem
// const rootDirectory = '/directory/to/transfer/source',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

trailing comma

/**
* Creates a request to transfer from the local file system to the sink bucket
*/
async function transferDirectory() {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is "transferDirectory" the right name for this function? This only transfers the files specified in the manifest right? which may not be the entire directory if i understand it correctly, and may in fact include files from multiple directories within the root directory

@danielbankhead danielbankhead restored the posix-samples branch June 15, 2022 01:54
gcf-merge-on-green bot pushed a commit that referenced this pull request Jun 30, 2022
🤖 I have created a release *beep* *boop*
---


## [2.1.0](v2.0.0...v2.1.0) (2022-06-30)


### Features

* **samples:** Add POSIX & Manifest samples ([#67](#67)) ([1056c9f](1056c9f))
* support regapic LRO ([#75](#75)) ([cc80906](cc80906))

---
This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
sofisl pushed a commit to googleapis/google-cloud-node that referenced this pull request Nov 11, 2022
🤖 I have created a release *beep* *boop*
---


## [2.1.0](googleapis/nodejs-storage-transfer@v2.0.0...v2.1.0) (2022-06-30)


### Features

* **samples:** Add POSIX & Manifest samples ([#67](googleapis/nodejs-storage-transfer#67)) ([1056c9f](googleapis/nodejs-storage-transfer@1056c9f))
* support regapic LRO ([#75](googleapis/nodejs-storage-transfer#75)) ([cc80906](googleapis/nodejs-storage-transfer@cc80906))

---
This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
kweinmeister pushed a commit to GoogleCloudPlatform/nodejs-docs-samples that referenced this pull request Jan 25, 2023
🤖 I have created a release *beep* *boop*
---


## [2.1.0](googleapis/nodejs-storage-transfer@v2.0.0...v2.1.0) (2022-06-30)


### Features

* **samples:** Add POSIX & Manifest samples ([#67](googleapis/nodejs-storage-transfer#67)) ([1056c9f](googleapis/nodejs-storage-transfer@1056c9f))
* support regapic LRO ([#75](googleapis/nodejs-storage-transfer#75)) ([cc80906](googleapis/nodejs-storage-transfer@cc80906))

---
This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
api: storagetransfer Issues related to the googleapis/nodejs-storage-transfer API. samples Issues that are directly related to samples. size: l Pull request size is large.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants