Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): fix broken dep types #549

Merged
merged 2 commits into from
Mar 6, 2019
Merged

chore(deps): fix broken dep types #549

merged 2 commits into from
Mar 6, 2019

Conversation

callmehiphop
Copy link
Contributor

A new patch release of sinon types came out yesterday and it looks like maybe the Stub type is borked. Pinning to previous patch release as a temporary solution.

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Mar 6, 2019
@callmehiphop callmehiphop added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Mar 6, 2019
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Mar 6, 2019
@callmehiphop callmehiphop changed the title chore(deps): pin sinon@7.0.8 chore(deps): fix broken dep types Mar 6, 2019
@callmehiphop
Copy link
Contributor Author

Looks like p-limit types have also been changed. In addition to that I noticed it was listed as a dependency, but looks like it was meant to be a dev dep?

@callmehiphop callmehiphop added do not merge Indicates a pull request not ready for merge, due to either quality or timing. and removed do not merge Indicates a pull request not ready for merge, due to either quality or timing. labels Mar 6, 2019
@callmehiphop callmehiphop merged commit c006852 into googleapis:master Mar 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants