docs: Update grammar #544
Merged
docs: Update grammar #544
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
corrected errors like "Execute a DML statements" to "Execute a DML statement", added punctuations. and made general edits to make sentences in the Active voice, and simpler.
googlebot
added
the
cla: yes
callmehiphop
reviewed
Mar 1, 2019
JustinBeckwith
previously requested changes
Mar 3, 2019
callmehiphop
suggested changes
Mar 4, 2019
addressed Review feedback.
callmehiphop
approved these changes
Mar 4, 2019
src/transaction.ts
Outdated
| * {@link Snapshot#run} for your convenience. All rows will | ||
| * be stored in memory before being released to your callback. If you intend | ||
| * on receiving a lot of results from your query, consider using the streaming | ||
| * {@link Snapshot#run} for your convenience. All rows are stored in memory before being released to your callback. |
There was a problem hiding this comment.
Definitely running over that 80 char limit here. Does npm run fix correct this?
callmehiphop
suggested changes
Mar 4, 2019
|
Thanks a lot. I left one suggestion in the comment. Please, let me know if
you are ok with it, else, I will revert the changes.
Regards,
Romola.
…On Mon, Mar 4, 2019 at 12:43 PM Dave Gramlich ***@***.***> wrote:
***@***.**** requested changes on this pull request.
I didn't mean to approve! Still a couple items that need to be resolved.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#544 (review)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ArJUBYQRmn5qNoCKIchDeURRdgvXUl8Zks5vTWlOgaJpZM4bZwPg>
.
|
addressed review comments.
AVaksman
added
the
kokoro:force-run
kokoro-team
removed
the
kokoro:force-run
AVaksman
added
the
kokoro:force-run
kokoro-team
removed
the
kokoro:force-run
callmehiphop
approved these changes
Mar 6, 2019
callmehiphop
added
the
kokoro:force-run
kokoro-team
removed
the
kokoro:force-run
callmehiphop
added
the
kokoro:force-run
kokoro-team
removed
the
kokoro:force-run
callmehiphop
added
the
kokoro:force-run
kokoro-team
removed
the
kokoro:force-run
callmehiphop
added
the
kokoro:force-run
kokoro-team
removed
the
kokoro:force-run
callmehiphop
added
the
kokoro:force-run
kokoro-team
removed
the
kokoro:force-run
callmehiphop
added
the
kokoro:force-run
kokoro-team
removed
the
kokoro:force-run
JustinBeckwith
added
the
kokoro:force-run
kokoro-team
removed
the
kokoro:force-run
Codecov Report
@@ Coverage Diff @@
## master #544 +/- ##
=========================================
Coverage ? 89.95%
=========================================
Files ? 15
Lines ? 1444
Branches ? 42
=========================================
Hits ? 1299
Misses ? 140
Partials ? 5
Continue to review full report at Codecov.
|
JustinBeckwith
added
the
kokoro:force-run
kokoro-team
removed
the
kokoro:force-run
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Corrected errors like "Execute a DML statements" to "Execute a DML statement", "If the callback is omitted, we'll return a Promise" to "If the callback is omitted, the function returns a Promise". Added punctuation, and made general edits to make sentences simpler, and in the Active voice.