Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(transaction): accept json options in run/runStream #446

Merged
merged 1 commit into from
Nov 21, 2018
Merged

fix(transaction): accept json options in run/runStream #446

merged 1 commit into from
Nov 21, 2018

Conversation

callmehiphop
Copy link
Contributor

@callmehiphop callmehiphop commented Nov 21, 2018 •
edited
Loading

Fixes #374

  • Tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Nov 21, 2018
JustinBeckwith
JustinBeckwith approved these changes Nov 21, 2018
View reviewed changes
Copy link
Contributor

@JustinBeckwith JustinBeckwith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Any idea if the system test failures are related?

@JustinBeckwith JustinBeckwith added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Nov 21, 2018
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Nov 21, 2018
@callmehiphop
Copy link
Contributor Author

@JustinBeckwith no idea, I couldn't view them.

@callmehiphop callmehiphop merged commit fbec31d into googleapis:master Nov 21, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stephenplusplus stephenplusplus stephenplusplus approved these changes

@JustinBeckwith JustinBeckwith JustinBeckwith approved these changes

Assignees
No one assigned
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@callmehiphop @JustinBeckwith @stephenplusplus @googlebot @kokoro-team