Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Only run mutations inside of a transaction. #361

Merged
merged 4 commits into from
Oct 16, 2018
Merged

Only run mutations inside of a transaction. #361

merged 4 commits into from
Oct 16, 2018

Conversation

stephenplusplus
Copy link
Contributor

@stephenplusplus stephenplusplus commented Oct 4, 2018 •
edited
Loading

Fixes #336
Fixes #347

To Dos

  • Use transactions for write operations
  • Unit tests

@googlebot
Copy link

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and have the pull request author add another comment and the bot will run again. If the bot doesn't comment, it means it doesn't think anything has changed.

@googlebot googlebot added the cla: no This human has *not* signed the Contributor License Agreement. label Oct 4, 2018
@ghost ghost assigned stephenplusplus Oct 4, 2018
stephenplusplus
stephenplusplus commented Oct 4, 2018
View reviewed changes
src/transaction-request.js
@@ -274,6 +274,17 @@ class TransactionRequest {
* ];
*/
deleteRows(table, keys, callback) {
if (!this.transaction) {

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

@stephenplusplus stephenplusplus mentioned this pull request Oct 4, 2018
Closed
@ghost ghost assigned JustinBeckwith Oct 5, 2018
crwilcox
crwilcox suggested changes Oct 5, 2018
View reviewed changes
src/transaction-request.js
if (!this.transaction) {
this.database.runTransaction((err, transaction) => {
if (err) {
callback(err);

This comment was marked as spam.

Sign in to view

@stephenplusplus
Copy link
Contributor Author

Another case of the "works for me, but not for Kokoro!" :( @callmehiphop could you try out the system tests on this when you have a chance?

@JustinBeckwith JustinBeckwith added cla: yes This human has signed the Contributor License Agreement. and removed cla: no This human has *not* signed the Contributor License Agreement. labels Oct 10, 2018
@googlebot
Copy link

A Googler has manually verified that the CLAs look good.

(Googler, please make sure the reason for overriding the CLA status is clearly documented in these comments.)

@googlebot
Copy link

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and have the pull request author add another comment and the bot will run again. If the bot doesn't comment, it means it doesn't think anything has changed.

@googlebot googlebot added cla: no This human has *not* signed the Contributor License Agreement. and removed cla: yes This human has signed the Contributor License Agreement. labels Oct 16, 2018
@JustinBeckwith JustinBeckwith added cla: yes This human has signed the Contributor License Agreement. and removed cla: no This human has *not* signed the Contributor License Agreement. labels Oct 16, 2018
@googlebot
Copy link

A Googler has manually verified that the CLAs look good.

(Googler, please make sure the reason for overriding the CLA status is clearly documented in these comments.)

@codecov
Copy link

codecov bot commented Oct 16, 2018 •
edited
Loading

Codecov Report

Merging #361 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #361      +/-   ##
==========================================
+ Coverage   99.54%   99.54%   +<.01%     
==========================================
  Files          12       12              
  Lines        1308     1316       +8     
==========================================
+ Hits         1302     1310       +8     
  Misses          6        6
Impacted Files Coverage Δ
src/transaction-request.js 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9596120...35805bf. Read the comment docs.

@JustinBeckwith JustinBeckwith merged commit 01602ab into googleapis:master Oct 16, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@crwilcox crwilcox crwilcox approved these changes

@callmehiphop callmehiphop Awaiting requested review from callmehiphop

Assignees

@JustinBeckwith JustinBeckwith

@stephenplusplus stephenplusplus

Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@stephenplusplus @googlebot @crwilcox @callmehiphop @JustinBeckwith