Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: change exists to return false on error code 5 #353

Merged
merged 3 commits into from
Oct 3, 2018
Merged

fix: change exists to return false on error code 5 #353

merged 3 commits into from
Oct 3, 2018

Conversation

callmehiphop
Copy link
Contributor

@callmehiphop callmehiphop commented Oct 2, 2018

Fixes #326

  • Tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

@callmehiphop callmehiphop requested a review from a team October 2, 2018 09:35
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Oct 2, 2018
@ghost ghost assigned callmehiphop Oct 2, 2018
@codecov
Copy link

codecov bot commented Oct 2, 2018

Codecov Report

❗ No coverage uploaded for pull request base (master@3d47e54). Click here to learn what that means.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #353   +/-   ##
=========================================
  Coverage          ?   99.53%           
=========================================
  Files             ?       12           
  Lines             ?     1300           
  Branches          ?        0           
=========================================
  Hits              ?     1294           
  Misses            ?        6           
  Partials          ?        0
Impacted Files Coverage Δ
src/database.js 97.45% <100%> (ø)
src/instance.js 100% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3d47e54...eb21fea. Read the comment docs.

@ghost ghost assigned JustinBeckwith Oct 2, 2018
@JustinBeckwith JustinBeckwith merged commit 8a3be8b into googleapis:master Oct 3, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants