Minor: wrap the inner error on retried transactions and return when deadline exceeded #309
Conversation
ghost
assigned 
googlebot
added
the
cla: yes
package.json
Outdated
| @@ -64,6 +64,7 @@ | |||
| "ycsb": "node ./benchmark/ycsb.js run -P ./benchmark/workloada -p table=usertable -p cloudspanner.instance=ycsb-instance -p operationcount=100 -p cloudspanner.database=ycsb" | |||
| }, | |||
| "dependencies": { | |||
| "@google-cloud/common": "^0.23.0", | |||
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
Codecov Report
@@ Coverage Diff @@
## master #309 +/- ##
==========================================
+ Coverage 99.61% 99.61% +<.01%
==========================================
Files 12 12
Lines 1294 1299 +5
==========================================
+ Hits 1289 1294 +5
Misses 5 5
Continue to review full report at Codecov.
|
| const formattedError = Transaction.createDeadlineError_(originalError); | ||
|
|
||
| assert.deepStrictEqual(expectedError, formattedError); | ||
| assert.strictEqual(formattedError.code, 4); |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
…pis/nodejs-spanner into maintain-inner-error-on-deadline
Codecov Report
@@ Coverage Diff @@
## master #309 +/- ##
==========================================
+ Coverage 99.53% 99.53% +<.01%
==========================================
Files 12 12
Lines 1278 1283 +5
==========================================
+ Hits 1272 1277 +5
Misses 6 6
Continue to review full report at Codecov.
|
…pis/nodejs-spanner into maintain-inner-error-on-deadline
src/transaction.js
Outdated
| code: 4, | ||
| message: 'Deadline for Transaction exceeded.', | ||
| }); | ||
| let apiError = new common.util.ApiError( |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
crwilcox
changed the title
…pis/nodejs-spanner into maintain-inner-error-on-deadline
Addresses some of the concerns from #216. When a transaction is retired beyond the allowed timeout the inner error is lost. This change holds the inner error.