feat: inline BeginTransaction with first statement #1692
fix: minor
- Loading branch information
commit dd9891ed4213ff805c5daa5a6d34c4dc7726a47e
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -570,7 +570,7 @@ export class Snapshot extends EventEmitter { | |
|
|
||
| if (this.id) { | ||
| transaction.id = this.id as Uint8Array; | ||
| } else if (this._options.readWrite) { | ||
| transaction.begin = this._options; | ||
| } else { | ||
| transaction.singleUse = this._options; | ||
|
|
@@ -615,7 +615,7 @@ export class Snapshot extends EventEmitter { | |
| json, | ||
| jsonOptions, | ||
| maxResumeRetries, | ||
| })?.on('response', response => { | ||
| if (response.metadata && response.metadata!.transaction && !this.id) { | ||
| this._update(response.metadata!.transaction); | ||
| } | ||
|
|
@@ -1040,7 +1040,7 @@ export class Snapshot extends EventEmitter { | |
| const transaction: spannerClient.spanner.v1.ITransactionSelector = {}; | ||
| if (this.id) { | ||
|
There was a problem hiding this comment. This does not take into account that a transaction could in theory have multiple requests in flight at the same time. If a transaction starts out with sending two Consider the following test case (the it('should only inline one begin transaction', async () => {
const database = newTestDatabase();
await database.runTransactionAsync(async tx => {
const rowCount1 = getRowCountFromStreamingSql(tx, {sql: selectSql});
const rowCount2 = getRowCountFromStreamingSql(tx, {sql: selectSql});
await Promise.all([rowCount1, rowCount2]);
await tx.commit();
});
await database.close();
let request = spannerMock.getRequests().find(val => {
return (val as v1.ExecuteSqlRequest).sql;
}) as v1.ExecuteSqlRequest;
assert.ok(request, 'no ExecuteSqlRequest found');
assert.deepStrictEqual(request.transaction!.begin!.readWrite, {});
assert.strictEqual(request.sql, selectSql);
request = spannerMock
.getRequests()
.slice()
.reverse()
.find(val => {
return (val as v1.ExecuteSqlRequest).sql;
}) as v1.ExecuteSqlRequest;
assert.ok(request, 'no ExecuteSqlRequest found');
assert.strictEqual(request.sql, selectSql);
assert.ok(request.transaction!.id, 'TransactionID is not set.');
const beginTxnRequest = spannerMock.getRequests().find(val => {
return (val as v1.BeginTransactionRequest).options?.readWrite;
}) as v1.BeginTransactionRequest;
assert.ok(!beginTxnRequest, 'beginTransaction was called');
});There was a problem hiding this comment. You're absolutely right. Added a lock that prevents a multiple inline begin transaction at the same time. Thanks! |
||
| transaction.id = this.id as Uint8Array; | ||
| } else if (this._options.readWrite) { | ||
| transaction.begin = this._options; | ||
| } else { | ||
| transaction.singleUse = this._options; | ||
|
|
@@ -1269,16 +1269,18 @@ export class Snapshot extends EventEmitter { | |
| private _wrapWithIdWaiter( | ||
| makeRequest: (resumeToken?: ResumeToken) => Readable): | ||
| (resumeToken?: ResumeToken) => Readable { | ||
| if (this.id || !this._options.readWrite) { | ||
| return makeRequest; | ||
| } | ||
| if (!this._inlineBeginStarted) { | ||
| this._inlineBeginStarted = true; | ||
| return makeRequest; | ||
| } | ||
| return (resumeToken?: ResumeToken): Readable => | ||
| this._idWaiter.once('notify', () => makeRequest(resumeToken) | ||
| .on('data', (chunk) => this._idWaiter.emit('data', chunk)) | ||
| .once('end', () => this._idWaiter.emit('end')) | ||
| ); | ||
| } | ||
| } | ||
|
|
||
|
|
||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would you mind adding a test that verifies the following:
PartialResultSets are returned by the stream, with (at least) one of them returning a resume token.UNAVAILABLEerror and the stream is restarted with a resume token.Step 3 should use the transaction ID that was returned by step 1, and not include a
BeginTransactionoption.(https://github.com/googleapis/nodejs-spanner/pull/1253/files is a very old implementation for the same. Some of the tests there might be re-usable.)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added. thanks a lot for this comment: it helped to find a bug in the code