chore: retry flaky tests for exceed administrative requests per minute quota error #1149
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
AVaksman
force-pushed
the
retry_failes_system_tests
branch
from
0cb6139 to
5cf9cfc
Compare
system-test/spanner.ts
Outdated
| @@ -44,6 +44,24 @@ const spanner = new Spanner({ | |||
| projectId: process.env.GCLOUD_PROJECT, | |||
| apiEndpoint: process.env.API_ENDPOINT, | |||
| }); | |||
| const RETRYOPTIONS: CallOptions = { | |||
There was a problem hiding this comment.
This is pretty trivial, but could this be renamed to GAX_OPTIONS? I'm thinking it might be more clear where it's used to understand the type of object we're providing.
Codecov Report
@@ Coverage Diff @@
## master #1149 +/- ##
=======================================
Coverage 98.34% 98.34%
=======================================
Files 21 21
Lines 20925 20925
Branches 1153 1153
=======================================
Hits 20579 20579
Misses 343 343
Partials 3 3 Continue to review full report at Codecov.
|
AVaksman
added
the
kokoro:force-run
yoshi-kokoro
removed
the
kokoro:force-run
skuruppu
reviewed
Jun 18, 2020
| @@ -44,6 +44,24 @@ const spanner = new Spanner({ | |||
| projectId: process.env.GCLOUD_PROJECT, | |||
| apiEndpoint: process.env.API_ENDPOINT, | |||
| }); | |||
| const GAX_OPTIONS: CallOptions = { | |||
There was a problem hiding this comment.
This looks great. Is it possible to add the same logic to the samples tests? The quota issue can happen in both types of tests.
skuruppu
approved these changes
Jun 18, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #1089, #1090, #1091 issues
Fixes #958