Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

export Float in index.ts #1720

Closed
john-twigg-ck opened this issue Oct 4, 2022 · 2 comments · Fixed by #1726 or #1752
Closed

export Float in index.ts #1720

john-twigg-ck opened this issue Oct 4, 2022 · 2 comments · Fixed by #1726 or #1752
Assignees
@asthamohta
Labels
api: spanner Issues related to the googleapis/nodejs-spanner API. priority: p3 Desirable enhancement or fix. May not be included in next release. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.

Comments

@john-twigg-ck
Copy link

https://github.com/googleapis/nodejs-spanner/blob/main/src/codec.ts#L125

I can convert TO Float using Spanner.float but I cannot easily make an interface to capture ORM being returned from the DB.

Example

// ??????
import { Float } from "@google-cloud/spanner/build/src/codec"
// ??????

export interface Trace {
    traceId: string
    flowName: string

    startTime: ISODateString

    endTime: ISODateString

    // Duration in uSeconds
    duration: Float
@john-twigg-ck john-twigg-ck added priority: p3 Desirable enhancement or fix. May not be included in next release. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design. labels Oct 4, 2022
@product-auto-label product-auto-label bot added the api: spanner Issues related to the googleapis/nodejs-spanner API. label Oct 4, 2022
@surbhigarg92 surbhigarg92 mentioned this issue Oct 19, 2022
Merged
@surbhigarg92
Copy link
Contributor

@john-twigg-ck Can you please review the #1726 . Will this resolve your issue ?

gcf-merge-on-green bot pushed a commit that referenced this issue Dec 15, 2022
@surbhigarg92
feat: export data types in index.ts (#1726)
844f57f 
Fixes #1720
@release-please release-please bot mentioned this issue Dec 15, 2022
Merged
@surbhigarg92
Copy link
Contributor

@john-twigg-ck Please reopen the issue , if PR does not address your issue.

gcf-merge-on-green bot pushed a commit that referenced this issue Dec 16, 2022
@release-please
chore(main): release 6.6.0 (#1752)
ba7029a 
🤖 I have created a release *beep* *boop*
---


## [6.6.0](https://togithub.com/googleapis/nodejs-spanner/compare/v6.5.0...v6.6.0) (2022-12-16)


### Features

* Export data types in index.ts ([#1726](https://togithub.com/googleapis/nodejs-spanner/issues/1726)) ([844f57f](https://togithub.com/googleapis/nodejs-spanner/commit/844f57fa5e79e5e5a5ede80df5e117004427f201)), closes [#1720](https://togithub.com/googleapis/nodejs-spanner/issues/1720)
* Fgac support and samples ([#1751](https://togithub.com/googleapis/nodejs-spanner/issues/1751)) ([0a394df](https://togithub.com/googleapis/nodejs-spanner/commit/0a394df9bfa193d79edc4c3a3d26238f361c0d45))


### Bug Fixes

* Add sleep after admin request intensive tests ([#1758](https://togithub.com/googleapis/nodejs-spanner/issues/1758)) ([7643ceb](https://togithub.com/googleapis/nodejs-spanner/commit/7643ceb7cde9f420539877b86fdb0d38b254348d))

---
This PR was generated with [Release Please](https://togithub.com/googleapis/release-please). See [documentation](https://togithub.com/googleapis/release-please#release-please).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@asthamohta asthamohta

Labels
api: spanner Issues related to the googleapis/nodejs-spanner API. priority: p3 Desirable enhancement or fix. May not be included in next release. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.
Projects
None yet
Milestone
No milestone
3 participants
@surbhigarg92 @john-twigg-ck @asthamohta