Skip to content
This repository was archived by the owner on Jul 13, 2023. It is now read-only.

refactor!: remove location path utility methods#243

Closed
yoshi-automation wants to merge 1 commit intomasterfrom
autosynth
Closed

refactor!: remove location path utility methods#243
yoshi-automation wants to merge 1 commit intomasterfrom
autosynth

Conversation

@yoshi-automation
Copy link
Contributor

This PR was generated using Autosynth. 🌈

Log from Synthtool
synthtool > Executing /tmpfs/src/git/autosynth/working_repo/synth.py.
synthtool > Ensuring dependencies.
synthtool > Cloning googleapis.
synthtool > Pulling Docker image: gapic-generator-typescript:latest
latest: Pulling from gapic-images/gapic-generator-typescript
Digest: sha256:a7f89dbac851b1daf372db435f555fcbd77551a66bfb6ea3a21457e616be156d
Status: Image is up to date for gcr.io/gapic-images/gapic-generator-typescript:latest
synthtool > Generating code for: google/cloud/redis/v1beta1.
synthtool > Generated code into /tmpfs/tmp/tmpf9mpld22.
synthtool > Pulling Docker image: gapic-generator-typescript:latest
latest: Pulling from gapic-images/gapic-generator-typescript
Digest: sha256:a7f89dbac851b1daf372db435f555fcbd77551a66bfb6ea3a21457e616be156d
Status: Image is up to date for gcr.io/gapic-images/gapic-generator-typescript:latest
synthtool > Generating code for: google/cloud/redis/v1.
synthtool > Generated code into /tmpfs/tmp/tmpq5vtnvjp.
.eslintignore
.eslintrc.yml
.github/ISSUE_TEMPLATE/bug_report.md
.github/ISSUE_TEMPLATE/feature_request.md
.github/ISSUE_TEMPLATE/support_request.md
.github/PULL_REQUEST_TEMPLATE.md
.github/release-please.yml
.jsdoc.js
.kokoro/common.cfg
.kokoro/continuous/node10/common.cfg
.kokoro/continuous/node10/docs.cfg
.kokoro/continuous/node10/lint.cfg
.kokoro/continuous/node10/samples-test.cfg
.kokoro/continuous/node10/system-test.cfg
.kokoro/continuous/node10/test.cfg
.kokoro/continuous/node12/common.cfg
.kokoro/continuous/node12/test.cfg
.kokoro/continuous/node8/common.cfg
.kokoro/continuous/node8/test.cfg
.kokoro/docs.sh
.kokoro/lint.sh
.kokoro/presubmit/node10/common.cfg
.kokoro/presubmit/node10/docs.cfg
.kokoro/presubmit/node10/lint.cfg
.kokoro/presubmit/node10/samples-test.cfg
.kokoro/presubmit/node10/system-test.cfg
.kokoro/presubmit/node10/test.cfg
.kokoro/presubmit/node12/common.cfg
.kokoro/presubmit/node12/test.cfg
.kokoro/presubmit/node8/common.cfg
.kokoro/presubmit/node8/test.cfg
.kokoro/presubmit/windows/common.cfg
.kokoro/presubmit/windows/test.cfg
.kokoro/publish.sh
.kokoro/release/docs.cfg
.kokoro/release/docs.sh
.kokoro/release/publish.cfg
.kokoro/samples-test.sh
.kokoro/system-test.sh
.kokoro/test.bat
.kokoro/test.sh
.kokoro/trampoline.sh
.nycrc
.prettierignore
.prettierrc
CODE_OF_CONDUCT.md
CONTRIBUTING.md
LICENSE
README.md
codecov.yaml
renovate.json
samples/README.md
synthtool > Replaced '/compute/docs/' in src/v1beta1/cloud_redis_client.ts.
synthtool > Replaced '/compute/docs/' in src/v1/cloud_redis_client.ts.
npm WARN npm npm does not support Node.js v12.13.1
npm WARN npm You should probably upgrade to a newer version of node as we
npm WARN npm can't make any promises that npm will work with this version.
npm WARN npm Supported releases of Node.js are the latest release of 6, 8, 9, 10, 11.
npm WARN npm You can find the latest version at https://nodejs.org/
npm WARN deprecated core-js@2.6.11: core-js@<3 is no longer maintained and not recommended for usage due to the number of issues. Please, upgrade your dependencies to the actual version of core-js@3.
npm WARN deprecated fsevents@1.2.9: One of your dependencies needs to upgrade to fsevents v2: 1) Proper nodejs v10+ support 2) No more fetching binaries from AWS, smaller package size

> core-js@2.6.11 postinstall /tmpfs/src/git/autosynth/working_repo/node_modules/core-js
> node -e "try{require('./postinstall')}catch(e){}"


> protobufjs@6.8.8 postinstall /tmpfs/src/git/autosynth/working_repo/node_modules/protobufjs
> node scripts/postinstall


> @google-cloud/redis@1.4.0 prepare /tmpfs/src/git/autosynth/working_repo
> npm run compile

npm WARN npm npm does not support Node.js v12.13.1
npm WARN npm You should probably upgrade to a newer version of node as we
npm WARN npm can't make any promises that npm will work with this version.
npm WARN npm Supported releases of Node.js are the latest release of 6, 8, 9, 10, 11.
npm WARN npm You can find the latest version at https://nodejs.org/

> @google-cloud/redis@1.4.0 compile /tmpfs/src/git/autosynth/working_repo
> tsc -p . && cp -r protos build/

npm notice created a lockfile as package-lock.json. You should commit this file.
npm WARN optional SKIPPING OPTIONAL DEPENDENCY: fsevents@1.2.9 (node_modules/fsevents):
npm WARN notsup SKIPPING OPTIONAL DEPENDENCY: Unsupported platform for fsevents@1.2.9: wanted {"os":"darwin","arch":"any"} (current: {"os":"linux","arch":"x64"})

added 972 packages from 1018 contributors and audited 7161 packages in 23.046s
found 0 vulnerabilities

npm WARN npm npm does not support Node.js v12.13.1
npm WARN npm You should probably upgrade to a newer version of node as we
npm WARN npm can't make any promises that npm will work with this version.
npm WARN npm Supported releases of Node.js are the latest release of 6, 8, 9, 10, 11.
npm WARN npm You can find the latest version at https://nodejs.org/

> @google-cloud/redis@1.4.0 fix /tmpfs/src/git/autosynth/working_repo
> gts fix && eslint --fix samples/*.js samples/**/*.js


/tmpfs/src/git/autosynth/working_repo/samples/quickstart.js
  24:38  error  "@google-cloud/redis" is not found  node/no-missing-require

✖ 1 problem (1 error, 0 warnings)

npm ERR! code ELIFECYCLE
npm ERR! errno 1
npm ERR! @google-cloud/redis@1.4.0 fix: `gts fix && eslint --fix samples/*.js samples/**/*.js`
npm ERR! Exit status 1
npm ERR! 
npm ERR! Failed at the @google-cloud/redis@1.4.0 fix script.
npm ERR! This is probably not a problem with npm. There is likely additional logging output above.

npm ERR! A complete log of this run can be found in:
npm ERR!     /home/kbuilder/.npm/_logs/2019-12-10T12_21_48_511Z-debug.log
installing semver@^5.5.0
installing minimist@^1.2.0
installing espree@^3.5.4
synthtool > Cleaned up 2 temporary directories.
synthtool > Wrote metadata to synth.metadata.

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Dec 10, 2019
@codecov
Copy link

codecov bot commented Dec 10, 2019

Codecov Report

Merging #243 into master will increase coverage by 0.54%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #243      +/-   ##
==========================================
+ Coverage   92.51%   93.06%   +0.54%     
==========================================
  Files           5        5              
  Lines        2645     2565      -80     
  Branches       89       89              
==========================================
- Hits         2447     2387      -60     
+ Misses        196      176      -20     
  Partials        2        2
Impacted Files Coverage Δ
src/v1/cloud_redis_client.ts 92.88% <ø> (+0.55%) ⬆️
src/v1beta1/cloud_redis_client.ts 92.88% <ø> (+0.55%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 362c159...9e63d3f. Read the comment docs.

@callmehiphop callmehiphop changed the title [CHANGE ME] Re-generated to pick up changes in the API or client library generator. refactor!: remove location path utility methods Dec 10, 2019
@alexander-fenster
Copy link
Contributor

Same as googleapis/nodejs-translate#402. Please do not merge until the logic is fixed in the generator. Cc: @xiaozhenliu-gg5

@alexander-fenster
Copy link
Contributor

Closing this, the next publish should be fine.

@alexander-fenster alexander-fenster deleted the autosynth branch December 10, 2019 23:38
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants