Skip to content

chore: fix promisify version to fix node 18 tests failure before we upgrade to node 18 #1566

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

chore: fix promisify version to fix node 18 tests failure before we upgrade to node 18 #1566

wants to merge 4 commits into from

Conversation

cindy-peng
Copy link
Contributor

…pgrade

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #<issue_number_goes_here> 🦕

@cindy-peng cindy-peng requested review from a team as code owners May 21, 2025 21:14
@cindy-peng cindy-peng requested a review from gkevinzheng May 21, 2025 21:14
@product-auto-label product-auto-label bot added size: xs Pull request size is extra small. api: logging Issues related to the googleapis/nodejs-logging API. labels May 21, 2025
@product-auto-label product-auto-label bot added size: s Pull request size is small. and removed size: xs Pull request size is extra small. labels May 21, 2025
@cindy-peng cindy-peng changed the title chore: fix promisify version to fix node 18 tests failure before we upgrade to node 19 chore: fix promisify version to fix node 18 tests failure before we upgrade to node 18 May 21, 2025
@product-auto-label product-auto-label bot added the stale: old Pull request is old and needs attention. label Jun 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gkevinzheng gkevinzheng Awaiting requested review from gkevinzheng gkevinzheng is a code owner automatically assigned from googleapis/api-logging

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
api: logging Issues related to the googleapis/nodejs-logging API. size: s Pull request size is small. stale: old Pull request is old and needs attention.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@cindy-peng