Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce async/await to test/order.ts #566

Merged
merged 1 commit into from
Mar 5, 2019

Conversation

schmidt-sebastian
Copy link
Contributor

#564 makes Serializer.encodeValue() synchronous.

This is a dumb PR to add no-op async/await to the current test/order.ts. It is meant to make #564 smaller.

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Mar 5, 2019
@codecov
Copy link

codecov bot commented Mar 5, 2019

Codecov Report

Merging #566 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #566   +/-   ##
=======================================
  Coverage   95.85%   95.85%           
=======================================
  Files          24       24           
  Lines        1931     1931           
  Branches      168      168           
=======================================
  Hits         1851     1851           
  Misses         57       57           
  Partials       23       23

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4ceac71...97a36f1. Read the comment docs.

1 similar comment
@codecov
Copy link

codecov bot commented Mar 5, 2019

Codecov Report

Merging #566 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #566   +/-   ##
=======================================
  Coverage   95.85%   95.85%           
=======================================
  Files          24       24           
  Lines        1931     1931           
  Branches      168      168           
=======================================
  Hits         1851     1851           
  Misses         57       57           
  Partials       23       23

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4ceac71...97a36f1. Read the comment docs.

@schmidt-sebastian schmidt-sebastian merged commit c92e1cf into master Mar 5, 2019
@schmidt-sebastian schmidt-sebastian deleted the mrschmidt-asyncorder branch March 5, 2019 05:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants