feat: Add support for new Firestore types #2337
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* feat: add MinKey and MaxKey. * feat: add RegexValue type. * feat: add ObjectIdValue type. * feat: add 32-bit integer type. * feat: Add BsonTimestampValue type. * feat: Add BsonBinaryData type. * WIP: Integration testing. * WIP: Added integration tests for using types in filters. * Expose new types for construction and add tests. * Do not perform data manipulation on the client side. * Address feedback (1). * Only use `Uint8Array` in the API. * Fix formatting. * Regex and ObjectId comparisons should use compareUtf8Strings. * Don't use static methods from field-value.ts * Address code review feedback. * Address code review feedback (tests, documentation, corner cases) * improve doc.
* fix: MinKey should be sorted after null. * add null to the minKey test case. * Remove unnecessary test. * fix node version for ci.
The tests titled `can use ... in filter` are removed as they test duplicate logic as `can filter and order ...`.
* Fix: Rename BsonTimestampValue to the correct name (BsonTimestamp). * Add range checks for BsonTimestamp. * Address feedback.
* Remove FieldValue factory methods. * Add comment for minkey and maxkey `instance()` methods.
product-auto-label
bot
added
size: xl
* WIP: feat: Add decimal128 support. * WIP: decimal128 tests added. Issue: +/-Infinity order. * properly handle NaN, -Infinity, and Infinity. * prettier. * Use Quadruple implementation. * Add tests and fix lint issues. * Add @internal and @Private tags to Quadruple implementation. * Fix .jsdoc.js to handle BigInt. * Fix the equality_matcher behavior around +0 and -0. * Address feedback.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support for MinKey, MaxKey, RegexValue, Int32Value, Decimal128Value, BsonObjectId, BsonTimestamp, and BsonBinaryData.