Skip to content
This repository has been archived by the owner on Sep 27, 2023. It is now read-only.

fix(test): increase minLikelihood option threshold to VERY_LIKELY #248

Merged
merged 2 commits into from
Mar 5, 2019

Conversation

jkwlui
Copy link
Member

@jkwlui jkwlui commented Mar 5, 2019

This one is annoying. I've personally fixed at least 3 instances of samples test failure due to some model changes in the DLP backend. We need a better way to test this.

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Mar 5, 2019
@jkwlui jkwlui requested a review from a team March 5, 2019 19:23
@jkwlui jkwlui self-assigned this Mar 5, 2019
@codecov
Copy link

codecov bot commented Mar 5, 2019

Codecov Report

Merging #248 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff          @@
##           master   #248   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files           1      1           
  Lines           4      4           
=====================================
  Hits            4      4

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cb27de5...8073b4c. Read the comment docs.

@JustinBeckwith
Copy link
Contributor

cc @googleapis/ml-apis

@JustinBeckwith JustinBeckwith merged commit 99461ad into master Mar 5, 2019
@stephenplusplus stephenplusplus deleted the fix-samples-test branch March 6, 2019 17:12
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants