Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: do not modify options object, use defaultScopes #751

Merged
merged 3 commits into from
Nov 7, 2020

Conversation

alexander-fenster
Copy link
Contributor

Regenerated the library using
gapic-generator-typescript
v1.2.1.

@alexander-fenster alexander-fenster requested a review from a team as a code owner November 6, 2020 22:25
@product-auto-label product-auto-label bot added the api: datastore Issues related to the googleapis/nodejs-datastore API. label Nov 6, 2020
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Nov 6, 2020
@bcoe bcoe added the automerge Merge the pull request once unit tests and other checks pass. label Nov 6, 2020
@gcf-merge-on-green gcf-merge-on-green bot merged commit 07a77fe into master Nov 7, 2020
@codecov
Copy link

codecov bot commented Nov 7, 2020

Codecov Report

Merging #751 (b75dff4) into master (e6473b7) will decrease coverage by 0.01%.
The diff coverage is 96.53%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #751      +/-   ##
==========================================
- Coverage   98.96%   98.94%   -0.02%     
==========================================
  Files          11       11              
  Lines        7837     7890      +53     
  Branches      476      515      +39     
==========================================
+ Hits         7756     7807      +51     
- Misses         79       81       +2     
  Partials        2        2              
Impacted Files Coverage Δ
src/v1/datastore_client.ts 96.94% <95.65%> (-0.01%) ⬇️
src/v1/datastore_admin_client.ts 97.80% <97.11%> (-0.05%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e6473b7...b75dff4. Read the comment docs.

@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label Nov 7, 2020
@alexander-fenster alexander-fenster deleted the ggt-1.2.1 branch November 7, 2020 00:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: datastore Issues related to the googleapis/nodejs-datastore API. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants