test: Ensure datastore transforms are working for transactions #1412
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…into 404540305-datastore-mode-data-transforms
…into 404540305-datastore-mode-data-transforms
product-auto-label
bot
added
size: l
danieljbruce
commented
Sep 15, 2025
| @@ -0,0 +1,42 @@ | |||
| // Copyright 2025 Google LLC | |||
There was a problem hiding this comment.
This file provides a mocked version of datastore that collects outgoing requests so that we can look at those requests in assert statements.
Base automatically changed from
404540305-datastore-mode-data-transforms
to
main
September 15, 2025 20:22
danieljbruce
dismissed
daniel-sanche’s stale review
The base branch was changed.
…into fix-transaction-spy # Conflicts: # system-test/datastore.ts
product-auto-label
bot
added
size: xl
daniel-sanche
approved these changes
Sep 15, 2025
danieljbruce
added
the
automerge
gcf-merge-on-green
bot
removed
the
automerge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR is a follow-up to the PR #1369 which adds datastore transforms support when the user does datastore.save. It turns out that for saves with transactions no further source code changes are required because transactions call the save method so this PR simply adds some tests for transactions that save with transforms.
Impact
Ensures datastore transforms work with transactions
Testing
Added tests where datastore transforms work with transactions.