fix: struct field names should not be lowercase (#364)

Co-authored-by: sofisl <55454395+sofisl@users.noreply.github.com>
googleapis · Aug 18, 2023 · 1867062 · 1867062
1 parent 07794c1
commit 1867062
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 7 deletions.
diff --git a/src/adapt/proto.ts b/src/adapt/proto.ts
@@ -220,7 +220,7 @@ function convertTableFieldSchemaToFieldDescriptorProto(
   scope: string,
   useProto3: boolean
 ): FieldDescriptorProto {
-  const name = `${field.name}`.toLowerCase();
+  const name = field.name;
   const type = field.type;
   if (!type) {
     throw Error(`table field ${name} missing type`);
@@ -241,7 +241,7 @@ function convertTableFieldSchemaToFieldDescriptorProto(
       throw Error(`table field type ${type} not supported`);
     }
     fdp = new FieldDescriptorProto({
-      name: field.name,
+      name: name,
       number: fNumber,
       type: pType,
       label: label,

diff --git a/test/adapt/proto.ts b/test/adapt/proto.ts
@@ -80,7 +80,7 @@ describe('Adapt Protos', () => {
             mode: 'NULLABLE',
           },
           {
-            name: 'details',
+            name: 'recordDetails',
             type: 'STRUCT',
             mode: 'REPEATED',
             fields: [
@@ -136,11 +136,11 @@ describe('Adapt Protos', () => {
             options: {},
           },
           {
-            name: 'details',
+            name: 'recordDetails',
             number: 2,
             label: 'LABEL_REPEATED',
             type: 'TYPE_MESSAGE',
-            typeName: 'Nested_details',
+            typeName: 'Nested_recordDetails',
           },
           {
             name: 'metadata',
@@ -152,7 +152,7 @@ describe('Adapt Protos', () => {
         ],
         nestedType: [
           {
-            name: 'Nested_details',
+            name: 'Nested_recordDetails',
             field: [
               {
                 name: 'key',
@@ -194,7 +194,7 @@ describe('Adapt Protos', () => {
       const NestedProto = (Type as any).fromDescriptor(protoDescriptor);
       const raw = {
         record_id: '12345',
-        details: [
+        recordDetails: [
           {key: 'name', value: 'jimmy'},
           {key: 'title', value: 'clown'},
         ],