This repository has been archived by the owner on Jul 13, 2023. It is now read-only.
build: use gapic-generator-typescript v1.0.7. #378
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This new generator will bring some changes to the generated code across all libraries, but the behavior will only change for nodejs-logging and nodejs-pubsub (those two libraries that use request batching). For other libraries, the changes should be minor (the createApiCall call is simplified) and it should be safe to merge them. Please talk to @alexander-fenster if you have any questions. PiperOrigin-RevId: 325949033 Source-Author: Google APIs <noreply@google.com> Source-Date: Mon Aug 10 21:11:13 2020 -0700 Source-Repo: googleapis/googleapis Source-Sha: 94006b3cb8d2fb44703cf535da15608eed6bf7db Source-Link: googleapis/googleapis@94006b3
google-cla
bot
added
the
cla: yes
Codecov Report
@@ Coverage Diff @@
## master #378 +/- ##
==========================================
+ Coverage 96.63% 96.70% +0.07%
==========================================
Files 15 15
Lines 5532 5529 -3
Branches 276 264 -12
==========================================
+ Hits 5346 5347 +1
+ Misses 180 176 -4
Partials 6 6
Continue to review full report at Codecov.
|
JustinBeckwith
approved these changes
Aug 11, 2020
JustinBeckwith
added
the
automerge
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR was generated using Autosynth. 🌈
Synth log will be available here:
https://source.cloud.google.com/results/invocations/5f7f9c6d-c75a-4c60-8bb8-0026a14cead7/targets
PiperOrigin-RevId: 325949033
Source-Link: googleapis/googleapis@94006b3