Skip to content
This repository has been archived by the owner on Jul 20, 2023. It is now read-only.

feat: add service_account to BatchPredictionJob in aiplatform v1beta1 batch_prediction_job.proto #278

Merged
merged 12 commits into from
Mar 17, 2022
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -200,6 +200,15 @@ message BatchPredictionJob {
// must be provided.
BatchDedicatedResources dedicated_resources = 7;

// The service account that the DeployedModel's container runs as. If not
// specified, a system generated one will be used, which
// has minimal permissions and the custom container, if used, may not have
// enough permission to access other GCP resources.
//
// Users deploying the Model must have the `iam.serviceAccounts.actAs`
// permission on this service account.
string service_account = 29;

// Immutable. Parameters configuring the batch behavior. Currently only applicable when
// [dedicated_resources][google.cloud.aiplatform.v1beta1.BatchPredictionJob.dedicated_resources] are used (in other cases Vertex AI does
// the tuning itself).
Expand Down
6 changes: 6 additions & 0 deletions protos/protos.d.ts

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

22 changes: 22 additions & 0 deletions protos/protos.js

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 4 additions & 0 deletions protos/protos.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

3 changes: 0 additions & 3 deletions test/gapic_dataset_service_v1.ts
Original file line number Diff line number Diff line change
Expand Up @@ -362,7 +362,6 @@ describe('v1.DatasetServiceClient', () => {
new protos.google.cloud.aiplatform.v1.GetDatasetRequest()
);
request.name = '';
const expectedHeaderRequestParams = 'name=';
const expectedError = new Error('The client has already been closed.');
client.close();
await assert.rejects(client.getDataset(request), expectedError);
Expand Down Expand Up @@ -493,7 +492,6 @@ describe('v1.DatasetServiceClient', () => {
);
request.dataset = {};
request.dataset.name = '';
const expectedHeaderRequestParams = 'dataset.name=';
const expectedError = new Error('The client has already been closed.');
client.close();
await assert.rejects(client.updateDataset(request), expectedError);
Expand Down Expand Up @@ -620,7 +618,6 @@ describe('v1.DatasetServiceClient', () => {
new protos.google.cloud.aiplatform.v1.GetAnnotationSpecRequest()
);
request.name = '';
const expectedHeaderRequestParams = 'name=';
const expectedError = new Error('The client has already been closed.');
client.close();
await assert.rejects(client.getAnnotationSpec(request), expectedError);
Expand Down
3 changes: 0 additions & 3 deletions test/gapic_dataset_service_v1beta1.ts
Original file line number Diff line number Diff line change
Expand Up @@ -362,7 +362,6 @@ describe('v1beta1.DatasetServiceClient', () => {
new protos.google.cloud.aiplatform.v1beta1.GetDatasetRequest()
);
request.name = '';
const expectedHeaderRequestParams = 'name=';
const expectedError = new Error('The client has already been closed.');
client.close();
await assert.rejects(client.getDataset(request), expectedError);
Expand Down Expand Up @@ -493,7 +492,6 @@ describe('v1beta1.DatasetServiceClient', () => {
);
request.dataset = {};
request.dataset.name = '';
const expectedHeaderRequestParams = 'dataset.name=';
const expectedError = new Error('The client has already been closed.');
client.close();
await assert.rejects(client.updateDataset(request), expectedError);
Expand Down Expand Up @@ -620,7 +618,6 @@ describe('v1beta1.DatasetServiceClient', () => {
new protos.google.cloud.aiplatform.v1beta1.GetAnnotationSpecRequest()
);
request.name = '';
const expectedHeaderRequestParams = 'name=';
const expectedError = new Error('The client has already been closed.');
client.close();
await assert.rejects(client.getAnnotationSpec(request), expectedError);
Expand Down
2 changes: 0 additions & 2 deletions test/gapic_endpoint_service_v1.ts
Original file line number Diff line number Diff line change
Expand Up @@ -362,7 +362,6 @@ describe('v1.EndpointServiceClient', () => {
new protos.google.cloud.aiplatform.v1.GetEndpointRequest()
);
request.name = '';
const expectedHeaderRequestParams = 'name=';
const expectedError = new Error('The client has already been closed.');
client.close();
await assert.rejects(client.getEndpoint(request), expectedError);
Expand Down Expand Up @@ -493,7 +492,6 @@ describe('v1.EndpointServiceClient', () => {
);
request.endpoint = {};
request.endpoint.name = '';
const expectedHeaderRequestParams = 'endpoint.name=';
const expectedError = new Error('The client has already been closed.');
client.close();
await assert.rejects(client.updateEndpoint(request), expectedError);
Expand Down
2 changes: 0 additions & 2 deletions test/gapic_endpoint_service_v1beta1.ts
Original file line number Diff line number Diff line change
Expand Up @@ -362,7 +362,6 @@ describe('v1beta1.EndpointServiceClient', () => {
new protos.google.cloud.aiplatform.v1beta1.GetEndpointRequest()
);
request.name = '';
const expectedHeaderRequestParams = 'name=';
const expectedError = new Error('The client has already been closed.');
client.close();
await assert.rejects(client.getEndpoint(request), expectedError);
Expand Down Expand Up @@ -493,7 +492,6 @@ describe('v1beta1.EndpointServiceClient', () => {
);
request.endpoint = {};
request.endpoint.name = '';
const expectedHeaderRequestParams = 'endpoint.name=';
const expectedError = new Error('The client has already been closed.');
client.close();
await assert.rejects(client.updateEndpoint(request), expectedError);
Expand Down
2 changes: 1 addition & 1 deletion test/gapic_featurestore_online_serving_service_v1.ts
Original file line number Diff line number Diff line change
Expand Up @@ -325,7 +325,6 @@ describe('v1.FeaturestoreOnlineServingServiceClient', () => {
new protos.google.cloud.aiplatform.v1.ReadFeatureValuesRequest()
);
request.entityType = '';
const expectedHeaderRequestParams = 'entity_type=';
const expectedError = new Error('The client has already been closed.');
client.close();
await assert.rejects(client.readFeatureValues(request), expectedError);
Expand Down Expand Up @@ -442,6 +441,7 @@ describe('v1.FeaturestoreOnlineServingServiceClient', () => {
const request = generateSampleMessage(
new protos.google.cloud.aiplatform.v1.StreamingReadFeatureValuesRequest()
);
request.entityType = '';
const expectedError = new Error('The client has already been closed.');
client.close();
const stream = client.streamingReadFeatureValues(request);
Expand Down
2 changes: 1 addition & 1 deletion test/gapic_featurestore_online_serving_service_v1beta1.ts
Original file line number Diff line number Diff line change
Expand Up @@ -325,7 +325,6 @@ describe('v1beta1.FeaturestoreOnlineServingServiceClient', () => {
new protos.google.cloud.aiplatform.v1beta1.ReadFeatureValuesRequest()
);
request.entityType = '';
const expectedHeaderRequestParams = 'entity_type=';
const expectedError = new Error('The client has already been closed.');
client.close();
await assert.rejects(client.readFeatureValues(request), expectedError);
Expand Down Expand Up @@ -442,6 +441,7 @@ describe('v1beta1.FeaturestoreOnlineServingServiceClient', () => {
const request = generateSampleMessage(
new protos.google.cloud.aiplatform.v1beta1.StreamingReadFeatureValuesRequest()
);
request.entityType = '';
const expectedError = new Error('The client has already been closed.');
client.close();
const stream = client.streamingReadFeatureValues(request);
Expand Down
5 changes: 0 additions & 5 deletions test/gapic_featurestore_service_v1.ts
Original file line number Diff line number Diff line change
Expand Up @@ -370,7 +370,6 @@ describe('v1.FeaturestoreServiceClient', () => {
new protos.google.cloud.aiplatform.v1.GetFeaturestoreRequest()
);
request.name = '';
const expectedHeaderRequestParams = 'name=';
const expectedError = new Error('The client has already been closed.');
client.close();
await assert.rejects(client.getFeaturestore(request), expectedError);
Expand Down Expand Up @@ -505,7 +504,6 @@ describe('v1.FeaturestoreServiceClient', () => {
new protos.google.cloud.aiplatform.v1.GetEntityTypeRequest()
);
request.name = '';
const expectedHeaderRequestParams = 'name=';
const expectedError = new Error('The client has already been closed.');
client.close();
await assert.rejects(client.getEntityType(request), expectedError);
Expand Down Expand Up @@ -644,7 +642,6 @@ describe('v1.FeaturestoreServiceClient', () => {
);
request.entityType = {};
request.entityType.name = '';
const expectedHeaderRequestParams = 'entity_type.name=';
const expectedError = new Error('The client has already been closed.');
client.close();
await assert.rejects(client.updateEntityType(request), expectedError);
Expand Down Expand Up @@ -779,7 +776,6 @@ describe('v1.FeaturestoreServiceClient', () => {
new protos.google.cloud.aiplatform.v1.GetFeatureRequest()
);
request.name = '';
const expectedHeaderRequestParams = 'name=';
const expectedError = new Error('The client has already been closed.');
client.close();
await assert.rejects(client.getFeature(request), expectedError);
Expand Down Expand Up @@ -918,7 +914,6 @@ describe('v1.FeaturestoreServiceClient', () => {
);
request.feature = {};
request.feature.name = '';
const expectedHeaderRequestParams = 'feature.name=';
const expectedError = new Error('The client has already been closed.');
client.close();
await assert.rejects(client.updateFeature(request), expectedError);
Expand Down
5 changes: 0 additions & 5 deletions test/gapic_featurestore_service_v1beta1.ts
Original file line number Diff line number Diff line change
Expand Up @@ -374,7 +374,6 @@ describe('v1beta1.FeaturestoreServiceClient', () => {
new protos.google.cloud.aiplatform.v1beta1.GetFeaturestoreRequest()
);
request.name = '';
const expectedHeaderRequestParams = 'name=';
const expectedError = new Error('The client has already been closed.');
client.close();
await assert.rejects(client.getFeaturestore(request), expectedError);
Expand Down Expand Up @@ -505,7 +504,6 @@ describe('v1beta1.FeaturestoreServiceClient', () => {
new protos.google.cloud.aiplatform.v1beta1.GetEntityTypeRequest()
);
request.name = '';
const expectedHeaderRequestParams = 'name=';
const expectedError = new Error('The client has already been closed.');
client.close();
await assert.rejects(client.getEntityType(request), expectedError);
Expand Down Expand Up @@ -640,7 +638,6 @@ describe('v1beta1.FeaturestoreServiceClient', () => {
);
request.entityType = {};
request.entityType.name = '';
const expectedHeaderRequestParams = 'entity_type.name=';
const expectedError = new Error('The client has already been closed.');
client.close();
await assert.rejects(client.updateEntityType(request), expectedError);
Expand Down Expand Up @@ -771,7 +768,6 @@ describe('v1beta1.FeaturestoreServiceClient', () => {
new protos.google.cloud.aiplatform.v1beta1.GetFeatureRequest()
);
request.name = '';
const expectedHeaderRequestParams = 'name=';
const expectedError = new Error('The client has already been closed.');
client.close();
await assert.rejects(client.getFeature(request), expectedError);
Expand Down Expand Up @@ -906,7 +902,6 @@ describe('v1beta1.FeaturestoreServiceClient', () => {
);
request.feature = {};
request.feature.name = '';
const expectedHeaderRequestParams = 'feature.name=';
const expectedError = new Error('The client has already been closed.');
client.close();
await assert.rejects(client.updateFeature(request), expectedError);
Expand Down
2 changes: 0 additions & 2 deletions test/gapic_index_endpoint_service_v1.ts
Original file line number Diff line number Diff line change
Expand Up @@ -379,7 +379,6 @@ describe('v1.IndexEndpointServiceClient', () => {
new protos.google.cloud.aiplatform.v1.GetIndexEndpointRequest()
);
request.name = '';
const expectedHeaderRequestParams = 'name=';
const expectedError = new Error('The client has already been closed.');
client.close();
await assert.rejects(client.getIndexEndpoint(request), expectedError);
Expand Down Expand Up @@ -515,7 +514,6 @@ describe('v1.IndexEndpointServiceClient', () => {
);
request.indexEndpoint = {};
request.indexEndpoint.name = '';
const expectedHeaderRequestParams = 'index_endpoint.name=';
const expectedError = new Error('The client has already been closed.');
client.close();
await assert.rejects(client.updateIndexEndpoint(request), expectedError);
Expand Down
2 changes: 0 additions & 2 deletions test/gapic_index_endpoint_service_v1beta1.ts
Original file line number Diff line number Diff line change
Expand Up @@ -374,7 +374,6 @@ describe('v1beta1.IndexEndpointServiceClient', () => {
new protos.google.cloud.aiplatform.v1beta1.GetIndexEndpointRequest()
);
request.name = '';
const expectedHeaderRequestParams = 'name=';
const expectedError = new Error('The client has already been closed.');
client.close();
await assert.rejects(client.getIndexEndpoint(request), expectedError);
Expand Down Expand Up @@ -510,7 +509,6 @@ describe('v1beta1.IndexEndpointServiceClient', () => {
);
request.indexEndpoint = {};
request.indexEndpoint.name = '';
const expectedHeaderRequestParams = 'index_endpoint.name=';
const expectedError = new Error('The client has already been closed.');
client.close();
await assert.rejects(client.updateIndexEndpoint(request), expectedError);
Expand Down
1 change: 0 additions & 1 deletion test/gapic_index_service_v1.ts
Original file line number Diff line number Diff line change
Expand Up @@ -357,7 +357,6 @@ describe('v1.IndexServiceClient', () => {
new protos.google.cloud.aiplatform.v1.GetIndexRequest()
);
request.name = '';
const expectedHeaderRequestParams = 'name=';
const expectedError = new Error('The client has already been closed.');
client.close();
await assert.rejects(client.getIndex(request), expectedError);
Expand Down
Loading