Implement skipIfExists for downloadBlobs in TransferManager#3505
Implement skipIfExists for downloadBlobs in TransferManager#3505nidhiii-27 wants to merge 2 commits intomainfrom
Conversation
- Added skipIfExists field and builder method to ParallelDownloadConfig. - Implemented skip logic in TransferManagerImpl.downloadBlobs to check for local file existence. - Added skip logic in DirectDownloadCallable for safety. - Added unit tests in ParallelDownloadConfigTest and TransferManagerTest. - Added integration test in ITTransferManagerTest. Co-authored-by: nidhiii-27 <224584462+nidhiii-27@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
This PR implements the
skipIfExistsoption for parallel downloads inTransferManager.When
skipIfExistsis set totrueinParallelDownloadConfig,TransferManager.downloadBlobswill check if the destination file already exists on the local filesystem. If it does, the download for that blob will be skipped, and the result will have a status ofSKIPPED.Changes:
skipIfExistsboolean and updated theBuilder.downloadBlobsto perform the existence check and skip downloads.skipIfExistsbefore starting the download.Unit tests passed successfully. Integration tests were added but verified manually due to environment-specific credential requirements.
PR created automatically by Jules for task 6849503870578500544 started by @nidhiii-27