chore: share do-with-timeout code #1324
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Refactor the execute methods a bit so they all share the same do-with-timeout logic.
product-auto-label
bot
added
size: m
rajatbhatta
approved these changes
Aug 25, 2023
| assertEquals(1, connection.prepareStatement(DML).executeUpdate()); | ||
| // TODO: Enable the next statement once PreparedStatement supports executing DDL through the | ||
| // executeUpdate() method. | ||
| // executeUpdate() method. |
There was a problem hiding this comment.
Please check if these blank spaces were added unintentionally..
There was a problem hiding this comment.
Yes, those are intentional. They make sure that the second line of the comment is part of the TODO, and is highlighted as such in the IDE.
olavloite
added a commit
that referenced
this pull request
Sep 15, 2023
…atement and PreparedStatement (#1321) * test: add tests for all execute methods of Statement and PreparedStatement Adds tests for all the different variations of the execute method on Statement and PreparedStatement. This will allow us to make internal changes to the way these methods are handled, while keeping control over any behavior changes that it might introduce. * chore: share do-with-timeout code (#1324) Refactor the execute methods a bit so they all share the same do-with-timeout logic.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor the execute methods a bit so they all share the same do-with-timeout logic.