Skip to content

chore: add java-shared-config to safe.directory and mark docker validation check as required#688

Merged
mpeddada1 merged 4 commits intomainfrom
test-docker-check
Oct 16, 2023
Merged

chore: add java-shared-config to safe.directory and mark docker validation check as required#688
mpeddada1 merged 4 commits intomainfrom
test-docker-check

Conversation

@mpeddada1
Copy link
Contributor

@mpeddada1 mpeddada1 commented Oct 16, 2023

The Kokoro - Test:Docker Image Validation is returning empty results for branchName and gitCommitMessage in #687. This is leading to the check passing for the incorrect reason (i.e the check passes even though gcr.io/cloud-devrel-public-resources/graalvma:1.6.0 has not been published.) Root cause from logs:

Executing: docker run --rm --interactive --network=host --privileged --volume=/var/run/docker.sock:/var/run/docker.sock --workdir=/tmpfs/src --entrypoint=github/java-shared-config/.kokoro/verify-docker-images.sh --env-file=/tmpfs/tmp/tmp80fng0kc/envfile --volume=/tmpfs:/tmpfs gcr.io/cloud-devrel-kokoro-resources/java8
fatal: detected dubious ownership in repository at '/tmpfs/src/github/java-shared-config'
To add an exception for this directory, call:

	git config --global --add safe.directory /tmpfs/src/github/java-shared-config
fatal: detected dubious ownership in repository at '/tmpfs/src/github/java-shared-config'
To add an exception for this directory, call:

	git config --global --add safe.directory /tmpfs/src/github/java-shared-config
fatal: detected dubious ownership in repository at '/tmpfs/src/github/java-shared-config'
To add an exception for this directory, call:

	git config --global --add safe.directory /tmpfs/src/github/java-shared-config

@product-auto-label product-auto-label bot added the size: xs Pull request size is extra small. label Oct 16, 2023
@product-auto-label product-auto-label bot added size: s Pull request size is small. and removed size: xs Pull request size is extra small. labels Oct 16, 2023
@mpeddada1
Copy link
Contributor Author

Adding git config --global --add safe.directory ... is now returning non-empty results for git name-rev and git log:

Check if git is installed:
/usr/bin/git
2f181de04aba21c33e340d6cd834d8f3a6267406
remotes/origin/test-docker-check

@product-auto-label product-auto-label bot added size: xs Pull request size is extra small. and removed size: s Pull request size is small. labels Oct 16, 2023
@generated-files-bot
Copy link

Warning: This pull request is touching the following templated files:

  • .github/sync-repo-settings.yaml

@mpeddada1 mpeddada1 changed the title test: troubleshoot kokoro docker image for validate docker check chore: add java-shared-config to safe.directory and mark docker validation check as required Oct 16, 2023
@mpeddada1 mpeddada1 marked this pull request as ready for review October 16, 2023 19:27
@mpeddada1 mpeddada1 requested a review from a team October 16, 2023 19:27
@mpeddada1 mpeddada1 merged commit df4385e into main Oct 16, 2023
@mpeddada1 mpeddada1 deleted the test-docker-check branch October 16, 2023 19:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size: xs Pull request size is extra small.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants