Skip to content

test: Flaky ConnectedCommitterImplTest #1078

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tmdiep merged 2 commits into from
Mar 10, 2022
Merged

test: Flaky ConnectedCommitterImplTest #1078

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a5e8b06
test: Flaky ConnectedCommitterImplTest
tmdiep Mar 6, 2022
a2c14dd
Merge branch 'refs/heads/main' into flaky_committer
tmdiep Mar 10, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions ...e/src/test/java/com/google/cloud/pubsublite/internal/wire/ConnectedCommitterImplTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -245,7 +245,7 @@ public void receiveTimeout_closesConnection() throws Exception {
verify(mockRequestStream).send(initialRequest());

// No subsequent stream responses should close the stream.
assertThat(connectionClosed.await(5, SECONDS)).isTrue();
assertThat(connectionClosed.await(30, SECONDS)).isTrue();

verify(mockRequestStream).closeSendWithError(argThat(new ApiExceptionMatcher(Code.ABORTED)));
verify(mockOutputStream).onError(argThat(new ApiExceptionMatcher(Code.ABORTED)));
Expand All @@ -271,7 +271,7 @@ public void initializationTimeout_closesConnection() throws Exception {
new ConnectedCommitterImpl(
streamFactory, mockOutputStream, initialRequest(), Duration.ofMillis(100));

assertThat(connectionClosed.await(5, SECONDS)).isTrue();
assertThat(connectionClosed.await(30, SECONDS)).isTrue();

verify(mockRequestStream).send(initialRequest());
verify(mockRequestStream).closeSendWithError(argThat(new ApiExceptionMatcher(Code.ABORTED)));
Expand Down