feat: Add a publisher cache for the pubsub lite sink #18
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
google-cla
bot
added
the
cla: yes
| evict(options); | ||
| } | ||
| }, | ||
| MoreExecutors.directExecutor()); |
Contributor
There was a problem hiding this comment.
don't use this- its liable to create weird deadlocks. Use SystemExecutors.alarmExecutor()
Contributor
Author
There was a problem hiding this comment.
Ah, thanks done!
refactoring tests
| import javax.annotation.Nullable; | ||
| import org.apache.flink.util.function.SerializableSupplier; | ||
|
|
||
| @AutoValue |
Contributor
There was a problem hiding this comment.
Is the user creating one of these? if so, add a builder.
Contributor
Author
There was a problem hiding this comment.
The user won't create this class directly. It's the portion of the settings which affect the publisher, but there will be a proper sinksettings class
Contributor
There was a problem hiding this comment.
Then get rid of the supplier from here please- if the supplier is present in the top level options, just use it instead of calling PublisherCache.get()
Contributor
Author
There was a problem hiding this comment.
Ah, fair enough, done.
palmere-google
force-pushed
the
palmere-dev-publish
branch
from
f0d62a9 to
2b9c9c9
Compare
dpcollins-google
approved these changes
Jul 27, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
Fixes #<issue_number_goes_here> ☕️