-
Notifications
You must be signed in to change notification settings - Fork 90
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
samples: allow only one pair of region tags #532
Conversation
Here is the summary of changes. You are about to delete 1 region tag.
This comment is generated by snippet-bot.
|
Warning: This pull request is touching the following templated files:
|
Codecov Report
@@ Coverage Diff @@
## master #532 +/- ##
=========================================
Coverage 78.85% 78.85%
Complexity 376 376
=========================================
Files 27 27
Lines 3414 3414
Branches 171 171
=========================================
Hits 2692 2692
Misses 650 650
Partials 72 72 Continue to review full report at Codecov.
|
This is very odd. Try using the exclude tag syntax instead of 2 duplicate region tags (which is allowed on cloud site, but not parsed in https://github.com/googleapis/synthtool/blob/master/synthtool/gcp/snippets.py) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think you need the region tag to exclude
Co-authored-by: Jeff Ching <chingor@google.com>
Co-authored-by: Jeff Ching <chingor@google.com>
Really odd. #527 actually messed up the README: