Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow user to configure usage of REST Transport #2074

Open
sanjivr opened this issue Jun 13, 2024 · 2 comments
Open

Allow user to configure usage of REST Transport #2074

sanjivr opened this issue Jun 13, 2024 · 2 comments
Assignees
Labels
api: pubsub Issues related to the googleapis/java-pubsub API. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.

Comments

@sanjivr
Copy link

sanjivr commented Jun 13, 2024

Is your feature request related to a problem? Please describe.

The PubSub Java SDK does not work when configured with InstantiatingHttpJsonChannelProvider.
It only supports InstantiatingGrpcChannelProvider. The Publisher implementation
provided by the SDK is tightly coupled with a Grpc transport.

Describe the solution you'd like

Update the Publisher and Subscriber implementations to support InstantiatingHttpJsonChannelProvider

Describe alternatives you've considered

None

Additional context

  • We have a requirement for on-premise clients to access PubSub only through a TLS terminating proxy
    which performs additional validation on request attributes to limit traffic to just allowlisted GCP projects
    or pubsub topics
    • In the TLS terminating mode, the proxy doesn't support grpc. As such all clients leveraging the official PubSub Java SDK are unable to utilize this TLS terminated proxy approach.
@product-auto-label product-auto-label bot added the api: pubsub Issues related to the googleapis/java-pubsub API. label Jun 13, 2024
@sanjivr
Copy link
Author

sanjivr commented Jun 13, 2024

We have patched the Publisher implementation to support InstantiatingHttpJsonChannelProvider
and verified that the same works for our use case.

#2075 illustrates the patch.

Please let us know whether there are any limitations in the implementation approach and
if it can be considered for general availability.

@michaelpri10
Copy link
Contributor

Hello! Thank you for raising this concern and your proposed patch. One concern we have is that this would bring the Java client library out-of-sync with our other client libraries. Additionally, a change like this will require a significant amount of testing to ensure that the new transport type is properly supported. I will be leaving this opened for now and will update with more information in the future as plans change or this becomes a priority for this client library.

@michaelpri10 michaelpri10 added the type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design. label Sep 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: pubsub Issues related to the googleapis/java-pubsub API. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.
Projects
None yet
Development

No branches or pull requests

2 participants