Skip to content

TopicName.parse could throw a more detailed ValidationException #1504

Open
@SimonScholz

Description

@SimonScholz

Recently I faced an issue when using the Topic.parse(String formattedString) method, because the String being used was an environment variable defined within a pod.
I could've been faster in resolving the issue, if the formattedString originating from the environment variable would be printed out as part of the ValidationException's message.

Also see my PR for this minor improvement: #1505

Current behavior:

The message TopicName.parse: formattedString not in valid format is shown.

throw new ValidationException("TopicName.parse: formattedString not in valid format");

Expected / desired behavior:

The message TopicName.parse: formattedString (${actual value of formattedString}) not in valid format is shown.

throw new ValidationException(
        "TopicName.parse: formattedString (%s) not in valid format", formattedString);

Metadata

Metadata

Assignees

Labels

api: pubsubIssues related to the googleapis/java-pubsub API.type: feature request‘Nice-to-have’ improvement, new feature or different behavior or design.

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions