Skip to content

chore: Run errorprone for JDK 17+ only #2023

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
lqiu96 merged 5 commits into from
Dec 18, 2025
Merged

chore: Run errorprone for JDK 17+ only #2023

lqiu96 merged 5 commits into from
Dec 18, 2025

Conversation

@lqiu96
Copy link
Member

@lqiu96 lqiu96 commented Dec 18, 2025 •
edited
Loading

@product-auto-label product-auto-label bot added size: s Pull request size is small. api: datastore Issues related to the googleapis/java-datastore API. labels Dec 18, 2025
@product-auto-label product-auto-label bot added size: m Pull request size is medium. and removed size: s Pull request size is small. labels Dec 18, 2025
@lqiu96 lqiu96 marked this pull request as ready for review December 18, 2025 18:45
@lqiu96 lqiu96 requested review from a team as code owners December 18, 2025 18:45
@lqiu96 lqiu96 requested a review from jinseopkim0 December 18, 2025 18:46
jinseopkim0
jinseopkim0 reviewed Dec 18, 2025
View reviewed changes
google-cloud-datastore/pom.xml
</plugin>
</plugins>
</build>
</profile>
Copy link
Contributor

@jinseopkim0 jinseopkim0 Dec 18, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why was it moved from pom.xml to google-cloud-datastore/pom.xml?

Copy link
Member Author

@lqiu96 lqiu96 Dec 18, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Edit: I got the libraries mixed up

Functionally there is no difference for this repo. I moved it just for consistency with other libraries as it should exist in the handwritten module (e.g. non-proto, non-grpc as they are auto generated and shouldn't care about errorprone warnings).

Copy link
Member Author

@lqiu96 lqiu96 Dec 18, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh wait, this is the datastore library not bigquery...

Copy link
Member Author

@lqiu96 lqiu96 Dec 18, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I updated this so that only handwritten modules run error prone and the other modules just run the normal compile plugin

@lqiu96 lqiu96 added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Dec 18, 2025
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Dec 18, 2025
@lqiu96
Copy link
Member Author

lqiu96 commented Dec 18, 2025

/gcbrun

@lqiu96 lqiu96 requested a review from jinseopkim0 December 18, 2025 20:53
@lqiu96 lqiu96 merged commit 3be8106 into main Dec 18, 2025
26 checks passed
@lqiu96 lqiu96 deleted the error-prone-configs branch December 18, 2025 21:27
blakeli0 added a commit that referenced this pull request Feb 3, 2026
@blakeli0 @diegomarquezp
@renovate-bot @cloud-java-bot @release-please @lqiu96
chore: Merge release v2.33.2 into protobuf-3.x (#2043)
803db3a 
* chore: add release-please config for protobuf-4.x (#2002)

* chore: add release-please config for protobuf-4.x

* Change release type from java-backport to java-yoshi

* deps: update dependency com.google.cloud:sdk-platform-java-config to v3.54.2 (#2011)

* deps: update googleapis/sdk-platform-java action to v2.64.2 (#2012)

* chore: Update generation configuration at Thu Dec 11 02:33:14 UTC 2025 (#1999)

* chore: Update generation configuration at Fri Nov 14 02:30:15 UTC 2025

* chore: Update generation configuration at Sat Nov 15 02:28:09 UTC 2025

* chore: Update generation configuration at Mon Nov 17 02:30:05 UTC 2025

* chore: Update generation configuration at Tue Nov 18 02:29:50 UTC 2025

* chore: Update generation configuration at Wed Nov 19 02:29:25 UTC 2025

* chore: generate libraries at Wed Nov 19 02:29:59 UTC 2025

* chore: Update generation configuration at Thu Nov 20 02:29:22 UTC 2025

* chore: Update generation configuration at Fri Nov 21 02:29:09 UTC 2025

* chore: Update generation configuration at Wed Nov 26 02:30:42 UTC 2025

* chore: Update generation configuration at Thu Nov 27 02:29:34 UTC 2025

* chore: Update generation configuration at Fri Nov 28 02:29:20 UTC 2025

* chore: Update generation configuration at Tue Dec  2 02:31:02 UTC 2025

* chore: Update generation configuration at Wed Dec  3 02:31:00 UTC 2025

* chore: Update generation configuration at Thu Dec  4 02:30:58 UTC 2025

* chore: Update generation configuration at Fri Dec  5 02:31:18 UTC 2025

* chore: Update generation configuration at Sat Dec  6 02:29:05 UTC 2025

* chore: Update generation configuration at Tue Dec  9 02:31:22 UTC 2025

* chore: Update generation configuration at Wed Dec 10 02:31:33 UTC 2025

* chore: Update generation configuration at Thu Dec 11 02:33:14 UTC 2025

* chore: generate libraries at Thu Dec 11 02:33:48 UTC 2025

* chore(main): release 2.33.1-SNAPSHOT (#1998)

:robot: I have created a release *beep* *boop*
---


### Updating meta-information for bleeding-edge SNAPSHOT release.

---
This PR was generated with [Release Please](https://togithub.com/googleapis/release-please). See [documentation](https://togithub.com/googleapis/release-please#release-please).

* chore(main): release 2.33.1 (#2013)

* chore(main): release 2.33.1

* chore: generate libraries at Thu Dec 11 22:21:16 UTC 2025

---------

Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
Co-authored-by: cloud-java-bot <cloud-java-bot@google.com>

* chore(main): release 2.33.2-SNAPSHOT (#2014)

:robot: I have created a release *beep* *boop*
---


### Updating meta-information for bleeding-edge SNAPSHOT release.

---
This PR was generated with [Release Please](https://togithub.com/googleapis/release-please). See [documentation](https://togithub.com/googleapis/release-please#release-please).

* chore: Run errorprone for JDK 17+ only (#2023)

* chore: Run errorprone for JDK 17+

* chore: Enable error prone for Java 17+

* chore: Set the error prone core version as a property

* chore: Add error prone configs in handwritten modules

* chore: generate libraries at Thu Dec 18 19:31:48 UTC 2025

---------

Co-authored-by: cloud-java-bot <cloud-java-bot@google.com>

* chore: cleanup release-please config (#2005)

* chore: cleanup release-please config

- Remove redundant options already declared at the top level.\n- Remove bumpMinorPreMajor for repositories after the first major release.

* chore: format release-please.yml

* chore: Update generation configuration at Tue Jan 13 21:59:16 UTC 2026 (#2015)

* chore: Update generation configuration at Fri Dec 12 02:32:40 UTC 2025

* chore: Update generation configuration at Sat Dec 13 02:30:22 UTC 2025

* chore: generate libraries at Sat Dec 13 02:30:51 UTC 2025

* chore: Update generation configuration at Mon Dec 15 02:35:52 UTC 2025

* chore: Update generation configuration at Tue Dec 16 02:33:05 UTC 2025

* chore: Update generation configuration at Wed Dec 17 02:31:09 UTC 2025

* chore: generate libraries at Wed Dec 17 02:31:38 UTC 2025

* chore: Update generation configuration at Thu Dec 18 02:31:20 UTC 2025

* chore: Update generation configuration at Fri Dec 19 02:32:33 UTC 2025

* chore: Update generation configuration at Sat Dec 20 02:30:15 UTC 2025

* chore: generate libraries at Sat Dec 20 02:30:47 UTC 2025

* chore: Update generation configuration at Wed Dec 24 02:32:17 UTC 2025

* chore: Update generation configuration at Thu Dec 25 02:34:09 UTC 2025

* chore: Update generation configuration at Tue Dec 30 02:34:32 UTC 2025

* chore: Update generation configuration at Wed Dec 31 02:34:34 UTC 2025

* chore: Update generation configuration at Tue Jan  6 02:36:10 UTC 2026

* chore: generate libraries at Tue Jan  6 02:36:41 UTC 2026

* chore: Update generation configuration at Wed Jan  7 02:35:49 UTC 2026

* chore: Update generation configuration at Thu Jan  8 02:35:40 UTC 2026

* chore: Update generation configuration at Fri Jan  9 02:36:14 UTC 2026

* chore: Update generation configuration at Sat Jan 10 02:32:36 UTC 2026

* chore: Update generation configuration at Tue Jan 13 02:35:07 UTC 2026

* chore: generate libraries at Tue Jan 13 02:35:35 UTC 2026

* chore: Update generation configuration at Tue Jan 13 21:59:16 UTC 2026

* chore: generate libraries at Tue Jan 13 21:59:42 UTC 2026

* deps: update dependency com.google.cloud:sdk-platform-java-config to v3.55.1 (#2027)

* deps: update googleapis/sdk-platform-java action to v2.65.1 (#2029)

* chore: Update generation configuration at Thu Jan 15 02:36:12 UTC 2026 (#2030)

* chore: Update generation configuration at Wed Jan 14 02:40:25 UTC 2026

* chore: generate libraries at Wed Jan 14 02:40:55 UTC 2026

* chore: Update generation configuration at Thu Jan 15 02:36:12 UTC 2026

---------

Co-authored-by: Diego Marquez <diegomarquezp@google.com>

* chore(main): release 2.33.2 (#2028)

* chore(main): release 2.33.2

* chore: generate libraries at Thu Jan 15 15:37:45 UTC 2026

---------

Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
Co-authored-by: cloud-java-bot <cloud-java-bot@google.com>

---------

Co-authored-by: Diego Marquez <diegomarquezp@google.com>
Co-authored-by: Mend Renovate <bot@renovateapp.com>
Co-authored-by: cloud-java-bot <122572305+cloud-java-bot@users.noreply.github.com>
Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
Co-authored-by: cloud-java-bot <cloud-java-bot@google.com>
Co-authored-by: Lawrence Qiu <lawrenceqiu@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jinseopkim0 jinseopkim0 jinseopkim0 approved these changes

Assignees

No one assigned

Labels

api: datastore Issues related to the googleapis/java-datastore API. size: m Pull request size is medium.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@lqiu96 @jinseopkim0 @yoshi-kokoro @cloud-java-bot