Skip to content

feat: enable flag for report generation #1991

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 27, 2025
Merged

feat: enable flag for report generation #1991

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8d71fd8
feat: enable flag for report generation
jinseopkim0 Oct 23, 2025
ef7593a
chore: remove clirr-maven-plugin override
jinseopkim0 Oct 23, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 1 addition & 4 deletions grpc-google-cloud-datastore-v1/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,10 +63,7 @@
<plugin>
<groupId>org.codehaus.mojo</groupId>
<artifactId>clirr-maven-plugin</artifactId>
<configuration>
<skip>true</skip> <!-- TODO(gapic_upgrade): remove after first release -->
</configuration>
</plugin>
Copy link
Member

@lqiu96 lqiu96 Oct 23, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think CLIRR should be enabled by default via shared-configs. Can you double check if we can just delete this entire block?

</plugins>
</build>
</project>
</project>