chore: use sdk-platform-java-config to consolidate build configs #1307
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Warning: This pull request is touching the following templated files:
|
product-auto-label
bot
added
the
api: datastore
burkedavison
approved these changes
Jan 30, 2024
gcf-owl-bot
bot
removed
the
owlbot:run
kolea2
added
automerge
gcf-owl-bot
bot
removed
the
owlbot:run
kolea2
removed
the
automerge
Contributor
|
@mpeddada1 it looks like owlbot reverted the renovate config changes - can you exclude them or should these be added upstream instead? |
Contributor
Author
|
Good catch, @kolea2! Let me try doing a one time update in synthtool: googleapis/synthtool#1921 |
…ic-updates-graalvm
…atastore into atomic-updates-graalvm
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Notable Changes:
gcr.io/cloud-devrel-public-resources/graalvm_sdk_platform*docker images for Kokoro GraalVM tests instead ofgcr.io/cloud-devrel-kokoro-resources/graalvm*.com.google.cloud:sdk-platform-java-configas the parent which inherits configs fromjava-shared-configand hosts thegoogle-cloud-shared-dependenciesversion under thegoogle-cloud-shared-dependencies.versionproperty. This artifact is versioned to be the same as google-cloud-shared-dependencies.sdk-platfrom-java-configis on Maven Central.Example renovate-bot update PR in google-cloud-java: googleapis/google-cloud-java#10290