Skip to content
This repository was archived by the owner on Jul 15, 2024. It is now read-only.

test: adding debug output in ITPaginationTest#684

Merged
gcf-merge-on-green[bot] merged 2 commits intogoogleapis:mainfrom
suztomo:adding_debug_output_in_ITPaginationTest
Apr 25, 2022
Merged

test: adding debug output in ITPaginationTest#684
gcf-merge-on-green[bot] merged 2 commits intogoogleapis:mainfrom
suztomo:adding_debug_output_in_ITPaginationTest

Conversation

@suztomo
Copy link
Member

@suztomo suztomo commented Apr 25, 2022

Troubleshooting for the flaky test #683.

@suztomo suztomo requested a review from a team as a code owner April 25, 2022 14:28
@product-auto-label product-auto-label bot added size: xs Pull request size is extra small. api: compute Issues related to the googleapis/java-compute API. labels Apr 25, 2022
@suztomo suztomo force-pushed the adding_debug_output_in_ITPaginationTest branch from 8e0c4e5 to 5d0070a Compare April 25, 2022 14:29
ListZonesRequest.newBuilder().setProject(DEFAULT_PROJECT).setMaxResults(1).build();
ZonesClient.ListPagedResponse response = zonesClient.list(listZonesRequest);
boolean presented = false;
int count = 0;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

optional: Perhaps we could name this numZones?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I go for count for shorter name.

Copy link
Member

@meltsufin meltsufin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you debug locally?

@product-auto-label product-auto-label bot added size: s Pull request size is small. and removed size: xs Pull request size is extra small. labels Apr 25, 2022
@suztomo suztomo force-pushed the adding_debug_output_in_ITPaginationTest branch from 2c35bbb to 5d0070a Compare April 25, 2022 15:04
@product-auto-label product-auto-label bot added size: xs Pull request size is extra small. and removed size: s Pull request size is small. labels Apr 25, 2022
@suztomo
Copy link
Member Author

suztomo commented Apr 25, 2022

@meltsufin No, I don't have local setup.

@suztomo suztomo added automerge Merge the pull request once unit tests and other checks pass. owlbot:run Add this label to trigger the Owlbot post processor. labels Apr 25, 2022
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Apr 25, 2022
@gcf-merge-on-green gcf-merge-on-green bot merged commit e7db3e2 into googleapis:main Apr 25, 2022
@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label Apr 25, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

api: compute Issues related to the googleapis/java-compute API. size: xs Pull request size is extra small.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants