chore: Move channel priming out of InstantiatingGrpcTransportProvider#2644
Merged
igorbernstein2 merged 20 commits intogoogleapis:mainfrom Jul 30, 2025
Merged
Conversation
nicholsl
changed the title
product-auto-label
bot
added
the
api: bigtable
mutianf
reviewed
Jul 29, 2025
...oud-bigtable/src/main/java/com/google/cloud/bigtable/data/v2/stub/BigtableClientContext.java
Outdated
Show resolved
Hide resolved
...oud-bigtable/src/main/java/com/google/cloud/bigtable/data/v2/stub/BigtableChannelPrimer.java
Show resolved
Hide resolved
...oud-bigtable/src/main/java/com/google/cloud/bigtable/data/v2/stub/BigtableClientContext.java
Outdated
Show resolved
Hide resolved
mutianf
previously approved these changes
Jul 29, 2025
...oud-bigtable/src/main/java/com/google/cloud/bigtable/data/v2/stub/BigtableClientContext.java
Outdated
Show resolved
Hide resolved
...oud-bigtable/src/main/java/com/google/cloud/bigtable/data/v2/stub/BigtableChannelPrimer.java
Outdated
Show resolved
Hide resolved
mutianf
changed the title
Change-Id: I7214aa3016bd7e7f7f167c64cbaa04134b54a352
Change-Id: I26d9b4929be6ba941eb88da05244fc031a747b68
nicholsl
force-pushed
the
chore/move-channel-priming-out
branch
from
2ae875d to
b535a44
Compare
Co-authored-by: Mattie Fu <mattiefu@google.com>
…data/v2/stub/BigtableClientContext.java Co-authored-by: Mattie Fu <mattiefu@google.com>
igorbernstein2
requested changes
Jul 29, 2025
...oud-bigtable/src/main/java/com/google/cloud/bigtable/data/v2/stub/BigtableChannelPrimer.java
Outdated
Show resolved
Hide resolved
...le-cloud-bigtable/src/main/java/com/google/cloud/bigtable/gaxx/grpc/BigtableChannelPool.java
Outdated
Show resolved
Hide resolved
...le-cloud-bigtable/src/main/java/com/google/cloud/bigtable/gaxx/grpc/BigtableChannelPool.java
Outdated
Show resolved
Hide resolved
Change-Id: I343b3dc44d12638be2af32398b6aaa8529c7ebfb
Change-Id: I2a11cd44ddd9caaea4db918f66aa7313a31a0057
Change-Id: I3e390b6f7a6c9beaee52d74f37ef557629af7759
igorbernstein2
requested changes
Jul 29, 2025
...e-cloud-bigtable/src/main/java/com/google/cloud/bigtable/data/v2/stub/NoOpChannelPrimer.java
Show resolved
Hide resolved
...e-cloud-bigtable/src/main/java/com/google/cloud/bigtable/data/v2/stub/NoOpChannelPrimer.java
Outdated
Show resolved
Hide resolved
...le-cloud-bigtable/src/main/java/com/google/cloud/bigtable/gaxx/grpc/BigtableChannelPool.java
Outdated
Show resolved
Hide resolved
...le-cloud-bigtable/src/main/java/com/google/cloud/bigtable/gaxx/grpc/BigtableChannelPool.java
Outdated
Show resolved
Hide resolved
...le-cloud-bigtable/src/main/java/com/google/cloud/bigtable/gaxx/grpc/BigtableChannelPool.java
Outdated
Show resolved
Hide resolved
Change-Id: I63f9f0e930f95d48ce56962e49d6bdca0fc5918d
feat/add-async-channel-ping add an async channel pinging method to be used in channel health checking
product-auto-label
bot
added
size: l
igorbernstein2
previously approved these changes
Jul 29, 2025
igorbernstein2
added
kokoro:force-run
yoshi-kokoro
removed
the
kokoro:force-run
Change-Id: Ia4e25a7c80256762e241f30a585056aa78fb2878
Change-Id: I96fb32e098862546aae0de498637459c5a9e197d
Change-Id: I8754683cae05ed9fd0267a1fd16746756450c15e
igorbernstein2
added
kokoro:force-run
yoshi-kokoro
removed
the
kokoro:force-run
Change-Id: I997c3752d8b5ae13084762a7eb3fc6b042ead206
Change-Id: I8e0ad310444c754df71dc61782b23d007bbfdaba
igorbernstein2
added
the
kokoro:force-run
yoshi-kokoro
removed
the
kokoro:force-run
mutianf
approved these changes
Jul 30, 2025
igorbernstein2
added
the
kokoro:force-run
yoshi-kokoro
removed
the
kokoro:force-run
igorbernstein2
approved these changes
Jul 30, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change-Id: I7214aa3016bd7e7f7f167c64cbaa04134b54a352
Move towards longterm goal of using InstantiatingGrpcTransportProvider as a simple channel factory and towards BigtableChannelPrimer having access to BigtableChannelPool directly
Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
Fixes #2643 ☕️
If you write sample code, please follow the samples format.