Skip to content

Conversation

@igorbernstein2
Copy link
Contributor

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)
  • Rollback plan is reviewed and LGTMed
  • All new data plane features have a completed end to end testing plan

Fixes #<issue_number_goes_here> ☕️

If you write sample code, please follow the samples format.

…client monitored resource

This will export a relevant subset of the metrics described in https://github.com/grpc/proposal/blob/master/A78-grpc-metrics-wrr-pf-xds.md as internal metrics to help rollout of DirectAccess

Change-Id: Ifddadb84d091f0f904f8f0f6e8da52de552e9757
Change-Id: I6eb3d8a2b387c4abf6a3a0b3fc470ff68b19ce8b
Change-Id: Iebbb983350e3d4368a0e6707aca32221d9bfa786
@igorbernstein2 igorbernstein2 requested review from a team as code owners March 31, 2025 21:07
@product-auto-label product-auto-label bot added size: m Pull request size is medium. api: bigtable Issues related to the googleapis/java-bigtable API. labels Mar 31, 2025
Change-Id: I38ed23e8d31591fc2bd8d0e5cc1f15dd7c518bce
Change-Id: Ie17b9389d423b34025d21dbad38828ddf3fa85bf
@igorbernstein2 igorbernstein2 requested a review from a team as a code owner March 31, 2025 21:30
Change-Id: I5763134f02026a484c814efe2c8ffa2ae9e046ac
@igorbernstein2 igorbernstein2 added the automerge Merge the pull request once unit tests and other checks pass. label Mar 31, 2025
@gcf-merge-on-green gcf-merge-on-green bot merged commit cd02090 into main Mar 31, 2025
22 checks passed
@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label Mar 31, 2025
@gcf-merge-on-green gcf-merge-on-green bot deleted the internal-metrics-4 branch March 31, 2025 22:16
andre-sampaio pushed a commit to andre-sampaio/java-bigtable that referenced this pull request Apr 24, 2025
)

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
- [ ] Make sure to open an issue as a [bug/issue](https://togithub.com/googleapis/java-bigtable/issues/new/choose) before writing your code!  That way we can discuss the change, evaluate designs, and agree on the general idea
- [ ] Ensure the tests and linter pass
- [ ] Code coverage does not decrease (if any source code was changed)
- [ ] Appropriate docs were updated (if necessary)
- [ ] Rollback plan is reviewed and LGTMed
- [ ] All new data plane features have a completed end to end testing plan

Fixes #<issue_number_goes_here> ☕️

If you write sample code, please follow the [samples format](
https://togithub.com/GoogleCloudPlatform/java-docs-samples/blob/main/SAMPLE_FORMAT.md).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: bigtable Issues related to the googleapis/java-bigtable API. size: m Pull request size is medium.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants