Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: reduce test noise #2257

Merged
merged 3 commits into from
Jun 12, 2024
Merged

test: reduce test noise #2257

merged 3 commits into from
Jun 12, 2024

Conversation

igorbernstein2
Copy link
Contributor

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)
  • Rollback plan is reviewed and LGTMed
  • All new data plane features have a completed end to end testing plan

Fixes #<issue_number_goes_here> ☕️

If you write sample code, please follow the samples format.

Change-Id: I50f954be0d6a0c5b4db6377e3403c81f3b14a167
- make sure to close stubs to avoid grpc warnings
- add missing plugin versions
- fix deprecated syntax in pom.xml
- filter out useless "Connecting to the Bigtable emulator..." log lines
- configure logs to be on a single line

Change-Id: Iacbd41c953ef0f3f726ef041dde0093d8bc2c6e6
@igorbernstein2 igorbernstein2 requested review from a team as code owners June 11, 2024 17:13
@product-auto-label product-auto-label bot added size: m Pull request size is medium. api: bigtable Issues related to the googleapis/java-bigtable API. labels Jun 11, 2024
@igorbernstein2 igorbernstein2 added kokoro:force-run Add this label to force Kokoro to re-run the tests. owlbot:run Add this label to trigger the Owlbot post processor. labels Jun 11, 2024
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Jun 11, 2024
Change-Id: I6cbd1c5d194112c7587f58337d7a810f81375ba7
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jun 11, 2024
@igorbernstein2 igorbernstein2 added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jun 11, 2024
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jun 11, 2024
@igorbernstein2 igorbernstein2 merged commit eea4eb0 into main Jun 12, 2024
22 of 23 checks passed
@igorbernstein2 igorbernstein2 deleted the test-noise branch June 12, 2024 15:59
ron-gal pushed a commit to ron-gal/java-bigtable that referenced this pull request Jul 23, 2024
* test: reduce noise by properly closing stubs

Change-Id: I50f954be0d6a0c5b4db6377e3403c81f3b14a167

* test: fix some of the noise during builds and test runs

- make sure to close stubs to avoid grpc warnings
- add missing plugin versions
- fix deprecated syntax in pom.xml
- filter out useless "Connecting to the Bigtable emulator..." log lines
- configure logs to be on a single line

Change-Id: Iacbd41c953ef0f3f726ef041dde0093d8bc2c6e6

* cleanup

Change-Id: I6cbd1c5d194112c7587f58337d7a810f81375ba7
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: bigtable Issues related to the googleapis/java-bigtable API. size: m Pull request size is medium.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants