Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Add instructions for migrating from HBase to Bigtable (offline via snapshots) #3197

Merged
merged 5 commits into from
Sep 7, 2021

Conversation

billyjacobson
Copy link
Contributor

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #<issue_number_goes_here> ☕️

@billyjacobson billyjacobson requested review from a team as code owners August 30, 2021 19:44
@product-auto-label product-auto-label bot added the api: bigtable Issues related to the googleapis/java-bigtable-hbase API. label Aug 30, 2021
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Aug 30, 2021
@billyjacobson billyjacobson requested a review from kolea2 August 30, 2021 19:46
Copy link
Contributor

@lesv lesv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I hate some the things here (like having bigtable-hbase-1.x-tools-1.20.0-SNAPSHOT-jar-with-dependencies.jar mentioned in source), but I can't suggest a better way, so LGTM.

@@ -57,7 +57,7 @@
* <p>Execute the following command to copy the schema from HBase to Cloud Bigtable:
*
* <pre>
* java -jar bigtable-hbase-1.x-tools-<your-version>-jar-with-dependencies.jar com.google.cloud.bigtable.hbase.tools.HBaseSchemaTranslator \
* java -jar bigtable-hbase-1.x-tools-1.20.0-SNAPSHOT-jar-with-dependencies.jar com.google.cloud.bigtable.hbase.tools.HBaseSchemaTranslator \
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please update version and remove -SNAPSHOT

billyjacobson and others added 4 commits August 31, 2021 14:55
… pipelines (googleapis#2949)

* docs:  Add README for HBase Tools and Beam import/export and validator pipelines.

* responding to some review comments

* more cleanups and adding hashes export and copy to bucket

* Reran through commands and fixed/cleaned up

* Cleanup for Jordan

* fix references to hbase-tools to hbase-1.x-tools

* update version
grammar
additional param info

* remove unnecessary commands
add timestamp to output file
Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
- [ ] Make sure to open an issue as a [bug/issue](https://github.com/googleapis/java-bigtable-hbase/issues/new/choose) before writing your code!  That way we can discuss the change, evaluate designs, and agree on the general idea
- [ ] Ensure the tests and linter pass
- [ ] Code coverage does not decrease (if any source code was changed)
- [ ] Appropriate docs were updated (if necessary)

Fixes #<issue_number_goes_here> ☕️
* docs: Fix broken links

* use more refined link

* update header in readme
@billyjacobson billyjacobson merged commit 17bda3a into googleapis:bigtable-1.x Sep 7, 2021
mutianf pushed a commit to mutianf/java-bigtable-hbase that referenced this pull request Sep 20, 2022
…via snapshots) (googleapis#3197)

* docs:  Add README for HBase Tools and Beam import/export and validator pipelines (googleapis#2949)

* docs:  Add README for HBase Tools and Beam import/export and validator pipelines.

* responding to some review comments

* more cleanups and adding hashes export and copy to bucket

* Reran through commands and fixed/cleaned up

* Cleanup for Jordan

* fix references to hbase-tools to hbase-1.x-tools

* update version
grammar
additional param info

* remove unnecessary commands
add timestamp to output file

* docs: fix readme title for Bigtable HBase tools (googleapis#3013)

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
- [ ] Make sure to open an issue as a [bug/issue](https://github.com/googleapis/java-bigtable-hbase/issues/new/choose) before writing your code!  That way we can discuss the change, evaluate designs, and agree on the general idea
- [ ] Ensure the tests and linter pass
- [ ] Code coverage does not decrease (if any source code was changed)
- [ ] Appropriate docs were updated (if necessary)

Fixes #<issue_number_goes_here> ☕️

* docs: Fix broken links for HBase Migration tools (googleapis#3097)

* docs: Fix broken links

* use more refined link

* update header in readme

* revert schema translator class

* Update link generators and typo
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: bigtable Issues related to the googleapis/java-bigtable-hbase API. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants