chore: feature parity for veneer attempt timeouts #3027
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
google-cla
bot
added
the
cla: yes
product-auto-label
bot
added
the
api: bigtable
* add attempt timeouts for reads. java-bigtable doesnt directly support per attempt timeouts for ReadRows. This PR works around it by setting a timeout in ApiCallContext for every call. Also, it ensures that the overall timeout is still respected after customized the attempt timeout * re-add the ability to "disable" timeouts. java-bigtable-hbase has a USE_TIMEOUTS config, which effectively ignores user configured deadlines and forces all by scans to use a 6 minute timeout. This config is deprecated and will be removed. But during the transition to veneer, we should keep it
igorbernstein2
force-pushed
the
attempt-timeouts
branch
from
35bca36 to
ff133c5
Compare
mutianf
approved these changes
Jun 23, 2021
...c/main/java/com/google/cloud/bigtable/hbase/wrappers/veneer/BigtableHBaseVeneerSettings.java
Outdated
Show resolved
Hide resolved
...c/main/java/com/google/cloud/bigtable/hbase/wrappers/veneer/BigtableHBaseVeneerSettings.java
Show resolved
Hide resolved
...bigtable-hbase/src/main/java/com/google/cloud/bigtable/hbase/wrappers/DataClientWrapper.java
Outdated
Show resolved
Hide resolved
....x-integration-tests/src/test/java/com/google/cloud/bigtable/hbase/TestRpcRetryBehavior.java
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on #3028