feat: improve handling when crossing async and sync boundaries #2976
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
product-auto-label
bot
added
the
api: bigtable
google-cla
bot
added
the
cla: yes
igorbernstein2
added a commit
to igorbernstein2/cloud-bigtable-client
that referenced
this pull request
May 19, 2021
igorbernstein2
added
the
kokoro:force-run
yoshi-kokoro
removed
the
kokoro:force-run
igorbernstein2
added
the
kokoro:force-run
yoshi-kokoro
removed
the
kokoro:force-run
igorbernstein2
added a commit
that referenced
this pull request
May 20, 2021
kolea2
approved these changes
May 21, 2021
Previously we would blindly uses ApiExceptions.callAndTranslateApiException and Futures.getUnchecked to await future results. This created a number of problems: * It would bubble ApiExceptions & CheckExceptions to the surface, which is quite unexpected for an hbase client * It would hide hbase specific IOExceptions This PR introduces FutureUtil#unwrap, which will try to preserve the original exception. However to aid in debugging, it will augment the stacktrace to include the caller. This is a similar approach as hbase took in: https://github.com/apache/hbase/blob/5b9940907e695e20d24968cbc725277a19ce2170/hbase-common/src/main/java/org/apache/hadoop/hbase/util/FutureUtils.java#L129-L140 Unfortunately we can't just call that utility because it only exists in hbase 2x, so I inlined relevant bits
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously we would blindly uses ApiExceptions.callAndTranslateApiException and Futures.getUnchecked to await future results. This created a number of problems:
This PR introduces FutureUtil#unwrap, which will try to preserve the original exception. However to aid in debugging, it will augment the stacktrace to include the caller. This is a similar approach as hbase took in:
https://github.com/apache/hbase/blob/5b9940907e695e20d24968cbc725277a19ce2170/hbase-common/src/main/java/org/apache/hadoop/hbase/util/FutureUtils.java#L129-L140
Unfortunately we can't just call that utility because it only exists in hbase 2x, so I inlined relevant bits
Also, a couple methods would skip the HBaseIOException wrapping, so I patched that in