chore: misc tweaks diffing 1x with master #2943
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
igorbernstein2
commented
Apr 26, 2021
igorbernstein2
commented
- port a couple of tests from 1x
- add a todo to investigate possible dead code
- clean avoid allocation for empty results
- fix user agent to be consistent with 1x
- remove stale benchmark that leaked implementation details
google-cla
bot
added
the
cla: yes
product-auto-label
bot
added
the
api: bigtable
* add a todo to investigate possible dead code * clean avoid allocation for empty results * fix user agent to be consistent with 1x * remove stale benchmark that leaked implementation details
igorbernstein2
force-pushed
the
misc-fixes
branch
from
8c13eee to
04237ef
Compare
mutianf
approved these changes
Apr 27, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.