-
Notifications
You must be signed in to change notification settings - Fork 180
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build: enable release-please for bigtable-1.x branch #2815
Conversation
Warning: This pull request is touching the following templated files:
|
Investigating why there was a second force-push after the PR was created that messed up the PR |
Turns out master and bigtable-1.x branches were both trying to release 1.20.0 and the branches stomped on each other. Will need to resolve the branch naming before we can merge this. |
@kolea2 The bot should now be using the feature with branch names that are separate per target branch so they don't collide. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
amazing!! Is this ready to merge? (label is still on)
Also a quick question - does this change also need to be added to the 1.x branch that we plan to do releases on?
* build: enable release-please for bigtable-1.x branch * chore: ignore release-please from synth templates
This should allow release-please to propose releases against the bigtable-1.x branch
To test, I ran against my own fork of this repo: