Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: enable release-please for bigtable-1.x branch #2815

Merged
merged 2 commits into from
Feb 3, 2021

Conversation

chingor13
Copy link
Contributor

@chingor13 chingor13 commented Jan 22, 2021

This should allow release-please to propose releases against the bigtable-1.x branch

To test, I ran against my own fork of this repo:

@chingor13 chingor13 requested a review from kolea2 January 22, 2021 20:28
@chingor13 chingor13 requested review from a team as code owners January 22, 2021 20:28
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Jan 22, 2021
@generated-files-bot
Copy link

Warning: This pull request is touching the following templated files:

  • .github/release-please.yml

@product-auto-label product-auto-label bot added the api: bigtable Issues related to the googleapis/java-bigtable-hbase API. label Jan 22, 2021
kolea2
kolea2 previously approved these changes Jan 22, 2021
@chingor13 chingor13 added the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Jan 22, 2021
@chingor13
Copy link
Contributor Author

Investigating why there was a second force-push after the PR was created that messed up the PR

@chingor13
Copy link
Contributor Author

Turns out master and bigtable-1.x branches were both trying to release 1.20.0 and the branches stomped on each other. Will need to resolve the branch naming before we can merge this.

@chingor13 chingor13 requested a review from kolea2 February 2, 2021 22:59
@chingor13
Copy link
Contributor Author

@kolea2 The bot should now be using the feature with branch names that are separate per target branch so they don't collide.

Copy link
Contributor

@kolea2 kolea2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

amazing!! Is this ready to merge? (label is still on)

Also a quick question - does this change also need to be added to the 1.x branch that we plan to do releases on?

@kolea2 kolea2 removed the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Feb 3, 2021
@kolea2 kolea2 merged commit c71e565 into googleapis:master Feb 3, 2021
kolea2 pushed a commit to kolea2/cloud-bigtable-client that referenced this pull request Feb 23, 2021
* build: enable release-please for bigtable-1.x branch

* chore: ignore release-please from synth templates
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: bigtable Issues related to the googleapis/java-bigtable-hbase API. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants