Skip to content

fix: Revive schema update e2e test and adjust some test names#921

Merged
stephaniewang526 merged 2 commits intogoogleapis:masterfrom
yirutang:jsonwriter
Mar 9, 2021
Merged

fix: Revive schema update e2e test and adjust some test names#921
stephaniewang526 merged 2 commits intogoogleapis:masterfrom
yirutang:jsonwriter

Conversation

@yirutang
Copy link
Contributor

@yirutang yirutang commented Mar 5, 2021

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #<issue_number_goes_here> ☕️

@yirutang yirutang requested review from a team and steffnay March 5, 2021 19:50
@product-auto-label product-auto-label bot added the api: bigquerystorage Issues related to the googleapis/java-bigquerystorage API. label Mar 5, 2021
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Mar 5, 2021
@codecov
Copy link

codecov bot commented Mar 5, 2021

Codecov Report

Merging #921 (a6f00fa) into master (ed33785) will decrease coverage by 0.37%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #921      +/-   ##
============================================
- Coverage     80.99%   80.61%   -0.38%     
+ Complexity     1021      976      -45     
============================================
  Files            76       76              
  Lines          5556     5432     -124     
  Branches        426      403      -23     
============================================
- Hits           4500     4379     -121     
+ Misses          879      878       -1     
+ Partials        177      175       -2     
Impacted Files Coverage Δ Complexity Δ
...bigquery/storage/v1alpha2/BigQueryWriteClient.java 77.61% <0.00%> (-2.91%) 28.00% <0.00%> (-10.00%)
...ery/storage/v1beta1/BaseBigQueryStorageClient.java 70.37% <0.00%> (-2.52%) 17.00% <0.00%> (-5.00%)
...ud/bigquery/storage/v1/BaseBigQueryReadClient.java 58.97% <0.00%> (-2.01%) 10.00% <0.00%> (-2.00%)
...gquery/storage/v1beta2/BaseBigQueryReadClient.java 58.97% <0.00%> (-2.01%) 10.00% <0.00%> (-2.00%)
...igquery/storage/v1beta1/BigQueryStorageClient.java 68.75% <0.00%> (-1.84%) 16.00% <0.00%> (-3.00%)
.../cloud/bigquery/storage/v1/BigQueryReadClient.java 51.51% <0.00%> (-1.43%) 8.00% <0.00%> (-1.00%)
...d/bigquery/storage/v1beta2/BigQueryReadClient.java 51.51% <0.00%> (-1.43%) 8.00% <0.00%> (-1.00%)
.../bigquery/storage/v1beta2/BigQueryWriteClient.java 74.13% <0.00%> (-1.25%) 26.00% <0.00%> (-7.00%)
...bigquery/storage/v1/stub/GrpcBigQueryReadStub.java 88.88% <0.00%> (-0.65%) 9.00% <0.00%> (-1.00%)
...ery/storage/v1beta2/stub/GrpcBigQueryReadStub.java 88.88% <0.00%> (-0.65%) 9.00% <0.00%> (-1.00%)
... and 21 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ed33785...a6f00fa. Read the comment docs.

@stephaniewang526 stephaniewang526 merged commit dd392e5 into googleapis:master Mar 9, 2021
gcf-merge-on-green bot pushed a commit that referenced this pull request Mar 10, 2021
🤖 I have created a release \*beep\* \*boop\*
---
## [2.0.0](https://www.github.com/googleapis/java-bigquerystorage/compare/v1.14.0...v2.0.0) (2021-03-09)


### ⚠ BREAKING CHANGES

* remove deprecated append method in StreamWriterV2 (#924)

### Features

* remove deprecated append method in StreamWriterV2 ([#924](https://www.github.com/googleapis/java-bigquerystorage/issues/924)) ([f278775](https://www.github.com/googleapis/java-bigquerystorage/commit/f2787751bf03d91d1575ee6e007f407f91d97157))


### Bug Fixes

* Revive schema update e2e test and adjust some test names ([#921](https://www.github.com/googleapis/java-bigquerystorage/issues/921)) ([dd392e5](https://www.github.com/googleapis/java-bigquerystorage/commit/dd392e54953e0b75e780532a4dab2d143b8d8665))


### Dependencies

* update dependency com.google.cloud:google-cloud-shared-dependencies to v0.20.1 ([#931](https://www.github.com/googleapis/java-bigquerystorage/issues/931)) ([8c716c5](https://www.github.com/googleapis/java-bigquerystorage/commit/8c716c5d26420ef03f76a302c76892894045d4ad))
---


This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
@yirutang yirutang deleted the jsonwriter branch April 30, 2021 19:00
shubhwip pushed a commit to shubhwip/java-bigquerystorage that referenced this pull request Oct 7, 2023
🤖 I have created a release *beep* *boop*
---


### Updating meta-information for bleeding-edge SNAPSHOT release.

---
This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: bigquerystorage Issues related to the googleapis/java-bigquerystorage API. cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants