fix: remove dependency on google-cloud-bigquery (cyclic dep)#1295
fix: remove dependency on google-cloud-bigquery (cyclic dep)#1295gcf-merge-on-green[bot] merged 8 commits intomasterfrom
Conversation
google-cla
bot
added
the
cla: yes
product-auto-label
bot
added
the
api: bigquerystorage
|
Warning: This pull request is touching the following templated files:
|
stephaniewang526
force-pushed
the
refactor
branch
from
99f900c to
60c5462
Compare
.../test/java/com/google/cloud/bigquery/storage/v1beta2/it/ITBigQueryWriteManualClientTest.java
Show resolved
Hide resolved
| String tableName = "MY_TABLE_NAME"; | ||
|
|
||
| writeToDefaultStream(projectId, datasetName, tableName); | ||
| TableFieldSchema strField = |
There was a problem hiding this comment.
I would suggest keep the sample the way it is. Move BQV2ToBQStorageConverter.java into sample as a lib, and the sample would still do a GetTable(), use BQV2ToBQStorageConverter to convert the schema and then use JsonWriter. It doesn't need to block this PR.
There was a problem hiding this comment.
Sure. Will make this change in a separate PR.
tswast
left a comment
tswast
left a comment
There was a problem hiding this comment.
I imagine you'll want a helper in the google-cloud-bigquery client for converting to the BQ Storage TableSchema once the v1 protos are available. That should be possible without a circular dependency.
| # Only dependencies with 'compile' or 'runtime' scope are included from original dependency list. | ||
| msg "Generating dependency list using original pom..." | ||
| mvn dependency:list -f pom.xml -DincludeScope=runtime -Dsort=true | grep '\[INFO] .*:.*:.*:.*:.*' | sed -e 's/ --.*//' >.org-list.txt | ||
| mvn dependency:list -f pom.xml -DincludeScope=runtime -DexcludeArtifactIds=gson,commons-codec,commons-logging,opencensus-contrib-http-util,httpclient,httpcore -Dsort=true | grep '\[INFO] .*:.*:.*:.*:.*' | sed -e 's/ --.*//' >.org-list.txt |
There was a problem hiding this comment.
Where is this exclusion list coming from? A template?
There was a problem hiding this comment.
Yes indeed. It comes from synthtool. There is a bug in maven-dependency-plugin which is causing this issue: https://issues.apache.org/jira/browse/MDEP-737
So we temporarily add this exclusion as a workaround.
stephaniewang526
added
automerge
yoshi-kokoro
removed
the
kokoro:force-run
gcf-merge-on-green
bot
removed
the
automerge
4 participants
Fixes #1249