-
Notifications
You must be signed in to change notification settings - Fork 130
deps: update bigquerystorage-bom to 3.20.0-rc1 #4035
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Summary of ChangesHello @diegomarquezp, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request focuses on a routine dependency update, specifically upgrading the Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request updates the google-cloud-bigquerystorage-bom dependency to 3.20.0-rc1, a release candidate. My review points out the potential stability risks of using pre-release dependencies. Even though the project seems to use other release candidates, it's a good practice to be cautious. I've recommended using stable versions unless this specific RC is required for testing.
| <groupId>com.google.cloud</groupId> | ||
| <artifactId>google-cloud-bigquerystorage-bom</artifactId> | ||
| <version>3.18.0</version> | ||
| <version>3.20.0-rc1</version> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This change introduces a dependency on a release candidate version (3.20.0-rc1). Release candidates are not stable and can introduce instability. Although the project already uses other pre-release versions (e.g., the parent POM is on an rc1 version), each new one adds to the potential risk. It is recommended to use stable versions unless this RC is needed for testing specific new features or fixes.
No description provided.