feat(bigquery): Support Fine Grained ACLs for Datasets #3803
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
product-auto-label
bot
added
size: m
whuffman36
requested review from
mrfaizal,
shollyman and
alvarowolfx
and removed request for
mrfaizal
shollyman
previously approved these changes
May 28, 2025
google-cloud-bigquery/src/main/java/com/google/cloud/bigquery/BigQuery.java
Outdated
Show resolved
Hide resolved
google-cloud-bigquery/src/main/java/com/google/cloud/bigquery/BigQuery.java
Outdated
Show resolved
Hide resolved
shollyman
previously approved these changes
May 28, 2025
|
The _UNSPECIFIED enum value seems a bit redundant to me, since the proto definition says that it will just default to FULL if unspecified. What do the other languages do here? |
This is a manifestation of https://google.aip.dev/126 which specifies the default (0 value) enum handles the unspecified case. It's a way of explicitly stating "use the service's default" value, which is documented as meaning "full" today but could potentially change in the future. |
shollyman
approved these changes
May 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the options dataset_view and update_mode to the get and patch dataset requests respectively. These new options decide whether the metadata and or ACL information should be checked when retrieving or updating a dataset.