Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding detailed message for import error #70

Closed

Conversation

sumit-ql
Copy link
Contributor

@sumit-ql sumit-ql commented Jul 9, 2019

Fix for #58.

Copy link
Contributor

@tseaver tseaver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have just merged #66, which should fix the docs build failure on CI and the lint failure in the system test file. Please fix the lint errors you've introduced here (run nox to check):

google/resumable_media/requests/__init__.py:671:9: E122 continuation line missing indentation or outdented
google/resumable_media/requests/__init__.py:674:1: W293 blank line contains whitespace
google/resumable_media/requests/__init__.py:676:18: W291 trailing whitespace

@sumit-ql
Copy link
Contributor Author

sumit-ql commented Jul 9, 2019

@tseaver Fixed the lint errors. Please review.

@tseaver
Copy link
Contributor

tseaver commented Jul 9, 2019

@sumit-ql Can you please rebase to pick up my changes from #66?

@tseaver
Copy link
Contributor

tseaver commented Jul 26, 2019

Superseded by #83.

@tseaver tseaver closed this Jul 26, 2019
tseaver added a commit that referenced this pull request Jul 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants