-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(deps): require six>=1.4.0 #194
Conversation
@@ -24,7 +24,7 @@ | |||
|
|||
|
|||
REQUIREMENTS = [ | |||
'six', | |||
'six>=1.4.0', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
From experimentation this was the lowest version that resulted in passing unit tests.
1.3.0 results in the following error:
_________________________________________ ERROR collecting tests_async/unit/requests/test_upload.py __________________________________________
Traceback (most recent call last):
File "/usr/local/google/home/busunkim/github/google-resumable-media-python/tests_async/unit/requests/test_upload.py", line 23, in <module>
import google._async_resumable_media.requests.upload as upload_mod
File "/usr/local/google/home/busunkim/github/google-resumable-media-python/google/_async_resumable_media/requests/__init__.py", line 661, in <module>
from google._async_resumable_media.requests.download import ChunkedDownload
File "/usr/local/google/home/busunkim/github/google-resumable-media-python/google/_async_resumable_media/requests/download.py", line 21, in <module>
from google._async_resumable_media.requests import _request_helpers
File "/usr/local/google/home/busunkim/github/google-resumable-media-python/google/_async_resumable_media/requests/_request_helpers.py", line 26, in <module>
import google.auth.transport._aiohttp_requests as aiohttp_requests
File "/usr/local/google/home/busunkim/github/google-resumable-media-python/.nox/unit-3-6/lib/python3.6/site-packages/google/auth/__init__.py", line 19, in <module>
from google.auth._default import default, load_credentials_from_file
File "/usr/local/google/home/busunkim/github/google-resumable-media-python/.nox/unit-3-6/lib/python3.6/site-packages/google/auth/_default.py", line 30, in <module>
import google.auth.transport._http_client
File "/usr/local/google/home/busunkim/github/google-resumable-media-python/.nox/unit-3-6/lib/python3.6/site-packages/google/auth/transport/__init__.py", line 41, in <module>
@six.add_metaclass(abc.ABCMeta)
AttributeError: module 'six' has no attribute 'add_metaclass'
add_metaclass
was added in 1.4.0 https://github.com/benjaminp/six/blob/42636b15dd1a5b85de56eac98e47954d4c776576/CHANGES#L248-L249
six
six
All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the ℹ️ Googlers: Go here for more info. |
…-python into add-constraints-file
All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the ℹ️ Googlers: Go here for more info. |
All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the ℹ️ Googlers: Go here for more info. |
@googlebot I consent. |
Of course, we are going to be ripping |
🤖 I have created a release \*beep\* \*boop\* --- ### [1.3.1](https://www.github.com/googleapis/google-resumable-media-python/compare/v1.3.0...v1.3.1) (2021-06-18) ### Bug Fixes * **deps:** require six>=1.4.0 ([#194](https://www.github.com/googleapis/google-resumable-media-python/issues/194)) ([a840691](https://www.github.com/googleapis/google-resumable-media-python/commit/a84069127cd48f68e3a56b3df16c63ff494637f3)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
fix(deps): add lower bound for
six
test: use constraints file to test lower bounds