fix(apache5): set connection request timeout on setTimeout #2129
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
diegomarquezp
changed the title
diegomarquezp
force-pushed
the
apache5-connection-request-config
branch
from
a53bce4 to
9de5064
Compare
product-auto-label
bot
added
size: m
blakeli0
reviewed
Dec 1, 2025
...lient-apache-v5/src/main/java/com/google/api/client/http/apache/v5/Apache5HttpTransport.java
Outdated
Show resolved
Hide resolved
blakeli0
reviewed
Dec 1, 2025
...t-apache-v5/src/test/java/com/google/api/client/http/apache/v5/Apache5HttpTransportTest.java
Outdated
Show resolved
Hide resolved
product-auto-label
bot
added
size: l
diegomarquezp
changed the title
product-auto-label
bot
added
size: s
product-auto-label
bot
added
size: m
product-auto-label
bot
added
size: s
blakeli0
reviewed
Dec 18, 2025
| public void setTimeout(int connectTimeout, int readTimeout) throws IOException { | ||
| requestConfig | ||
| .setConnectTimeout(Timeout.of(connectTimeout, TimeUnit.MILLISECONDS)) | ||
| .setConnectionRequestTimeout(connectTimeout, TimeUnit.MILLISECONDS) |
There was a problem hiding this comment.
Do you mind adding javadocs for it? Looks like setConnectionRequestTimeout is a Apache client thing and does not exist in other implementations such as NetHttpRequest. So we may want to add docs only to this method not the interface.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses an issue where
setConnectionRequestTimeoutwas not being honored byApache5HttpTransport.The root cause was that
Apache5HttpRequestcreated a newRequestConfigfor each request, overwriting the default configuration set on theHttpClient.Changes:
setConnectionRequestTimeoutas a setting affected bysetTimeout(int, int)so that it uses theconnectTimeoutargument.