chore: fix declaration of maven-source-plugin for v3.3.0#1922
Merged
chore: fix declaration of maven-source-plugin for v3.3.0#1922
Conversation
suztomo
approved these changes
Jan 26, 2024
Contributor
Author
|
The kokoro failure is unrelated to the changes in the PR. See googleapis/java-shared-config#712 (comment) for similar observation in a different repo. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The release job is currently failing with:
This started happening after we included the native-image-shared-config artifact.The parent pom brings in
maven-source-plugin:3.3.0in thereleaseprofile` :https://github.com/googleapis/java-shared-config/blob/28b2c77ddd2078d628cb8f2b16fae8efd0e673a5/native-image-shared-config/pom.xml#L107-L121.
This PR leverages
pluginManagementinstead of duplicating the setting in all the module poms to address the issue. This is similar to how google-aut-library-java is set up.BEGIN_COMMIT_OVERRIDE
fix: fixing declaration of maven-source-plugin for release job
END_COMMIT_OVERRIDE